From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id F2C2D1F9FD for ; Mon, 15 Mar 2021 05:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230028AbhCOFmZ (ORCPT ); Mon, 15 Mar 2021 01:42:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbhCOFmG (ORCPT ); Mon, 15 Mar 2021 01:42:06 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99E93C061574 for ; Sun, 14 Mar 2021 22:42:06 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id e7so15816274edu.10 for ; Sun, 14 Mar 2021 22:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NVqsgeSZXRjSL4Nd0xIheqgwZk5T6p6uNnVaoxv3OCc=; b=alyjcFtXDKIIS5dwfHZofKBL/uk3XTgYwWK4AKhqvxzsiYhCQD9NwhN6VJTafYJQSA yh+XEVbZmti/uNuWfjv73/fnlunz9dc5KvAZUEA0gApvNo0JjIjMVL0w9A2siXgu8hh+ M0PSjoW/Hh+NOMpDlzGs6RmETg33fpE8xx1i0BS1cQldv5f3zDRH4OR60RbhqVC4Unng 9XEyvtRf/18Txi5c6+NjDCX0NblXF3oVBxHPdJ0VI+p8i2HL8RtJTKmBtK8BixfQRgmp UJ/3a1Zz+zbJT3vo1A+sTAWtEEtp60k1WK9D/aeRSN2HQbCNfeywyeVF3r+ixDeP3uk4 lffg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NVqsgeSZXRjSL4Nd0xIheqgwZk5T6p6uNnVaoxv3OCc=; b=cZrkoCCjLIk2uN+wlb3r3Nw0iYDs+pEXNljZnVjLKaskBDByCqZYBRLJX2cSkW7C7t IezSMIgTuj9dLmmv+vVdbkFOuuI0rkzqh2FIQvV3soY+gi7huRQ5Uz++c/+i5KFJsmkG NM0RXa8wJn0PD+idL3OKmOxBhA9ZEihLjgUh1+uhK7bar8+b5CWcF4/1SxnJcFTOI0SS /xsQhWE2KrZLClIJmy46Ji3Ds1mymGUoTm/xR2lZLdK5U3R17Ua/Pfux3BGWi2VNtbO2 6I+ewNgRWfxlbkC8zvzaEfXH14aoGH9t0V0p5vn2nDzEi4TKWL2SfdzmKIllflcWRaU/ Q82w== X-Gm-Message-State: AOAM5313we104l2Vsh8hzB2aL2ZPSLcGXLGPHM6kGj2ce3X9mX1zjX09 TSuF2iTS2fiQ+QjwSOHVsPV5GebKSYPUcaCt+Lo= X-Google-Smtp-Source: ABdhPJze0RiVviEpnkB9Y7vEUtiHI2gsoGd1Nj+c6CI5ut1i3C83zZfOO80KEvfDumm0U7n8fjnHSFswzP/rIYeyXG8= X-Received: by 2002:aa7:d503:: with SMTP id y3mr27764274edq.142.1615786925361; Sun, 14 Mar 2021 22:42:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christian Couder Date: Mon, 15 Mar 2021 06:41:54 +0100 Message-ID: Subject: Re: [PATCH v5] [GSOC] commit: add --trailer option To: ZheNing Hu via GitGitGadget Cc: git , "Bradley M. Kuhn" , Junio C Hamano , Brandon Casey , Shourya Shukla , Rafael Silva , ZheNing Hu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Mar 15, 2021 at 6:33 AM Christian Couder wrote: > > On Mon, Mar 15, 2021 at 4:24 AM ZheNing Hu via GitGitGadget > wrote: > > > diff --git a/builtin/commit.c b/builtin/commit.c > > index 739110c5a7f6..24fccb561398 100644 > > --- a/builtin/commit.c > > +++ b/builtin/commit.c > > @@ -113,6 +113,9 @@ static int config_commit_verbose = -1; /* unspecified */ > > static int no_post_rewrite, allow_empty_message, pathspec_file_nul; > > static char *untracked_files_arg, *force_date, *ignore_submodule_arg, *ignored_arg; > > static char *sign_commit, *pathspec_from_file; > > +struct child_process run_trailer = CHILD_PROCESS_INIT; > > It seems to me that `run_trailer` is used only in the `if > (trailer_args.nr) {...}` block, so it could be declared there instead > of as a global variable. > > > +struct strvec trailer_args = STRVEC_INIT; Also you might want to add "static" in front of "struct strvec" in the above line.