mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Christian Couder <>
To: ZheNing Hu <>
Cc: Hariom verma <>,
Subject: Re: [OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal]
Date: Mon, 31 Oct 2022 15:41:45 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi ZheNing and Wilberforce,

On Mon, Oct 31, 2022 at 3:26 PM ZheNing Hu <> wrote:
> Hariom verma <> 于2022年10月28日周五 16:08写道:

> > > Olga<> has done great work in “Unifying Git’s
> > > format languages” during Outreachy Round 15 and continued even after
> > > that [from 28-09-2017 to 04-04-2019]. Her work is mostly related to
> > > `cat-file` and `ref-filter`.
> > >
> > > She already did a pretty nice job in preparing ref-filter for more
> > > general usage of its formatting logic. It will give me the possibility
> > > to make the migration of pretty.c easier.
> >
> > ZheNing Hu continued the Olga's work during GSoC'21. You can tell a
> > bit more about that too.
> I'm afraid I'm skeptical about the progress of this project. Yes, this
> project has
> been going on for too long, probably 3 years, and it is long overdue
> to be merged
> into master. Maybe we all need to rethink the nature of this project instead of
> rushing to start writing code.
> As far as I know, these unified format refactor are easy to implement, but as we
> use more complex parsing logic, there will be a lot of performance degradation.
> I recommend new contributors to perform performance analysis and performance
> optimization directly based on the original developer's patches.

Yeah, I agree that the project to use ref-filter formats in cat-file
is very hard due to performance issues, and I think we shouldn't
suggest it anymore as a project to GSoC or Outreachy applicants.

The project we are proposing for Outreachy, and that Wilberforce is
writing a proposal for, is about unifying "ref-filter formats" with
"pretty formats" though. So there is no need to touch cat-file code as
"pretty formats" are not used there. Actually it might not even be
needed to mention using ref-filter formats in cat-file (and the
related work made by Olga and ZheNing on this). It could perhaps help
with understanding the big picture, but that's it.


      reply	other threads:[~2022-10-31 14:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 11:58 [OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal] NSENGIYUMVA WILBERFORCE
2022-10-28  8:05 ` Hariom verma
2022-10-30 10:13   ` NSENGIYUMVA WILBERFORCE
2022-10-31 13:37     ` NSENGIYUMVA WILBERFORCE
2022-10-31 13:59       ` Hariom verma
2022-10-31 14:26   ` ZheNing Hu
2022-10-31 14:41     ` Christian Couder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).