From: Christian Couder <firstname.lastname@example.org> To: Jeff King <email@example.com> Cc: "Dominik Mahrer (Teddy)" <firstname.lastname@example.org>, git <email@example.com> Subject: Re: NO_MSGFMT Date: Sun, 12 Nov 2017 18:32:11 +0100 [thread overview] Message-ID: <CAP8UFD2gKTourXUdB_9_FZ3AEECTDc1Fx1NFKzeaTZDWHC3jxA@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Sun, Nov 12, 2017 at 12:57 PM, Jeff King <email@example.com> wrote: > On Sun, Aug 13, 2017 at 12:58:13AM -0400, Jeff King wrote: > >> On Sat, Aug 12, 2017 at 03:44:17PM +0200, Dominik Mahrer (Teddy) wrote: >> >> > Hi all >> > >> > I'm compiling git from source code on a mashine without msgfmt. This leads >> > to compile errors. To be able to compile git I created a patch that at least >> > works for me: >> >> Try: >> >> make NO_MSGFMT=Nope NO_GETTEXT=Nope >> >> This also works: >> >> make NO_GETTEXT=Nope NO_TCLTK=Nope >> >> The flags to avoid gettext/msgfmt are sadly different between git itself >> and git-gui/gitk, which we include as a subproject. It would be a useful >> patch to harmonize though (probably by accepting both in all places for >> compatibility). > > I saw somebody else today run into problems about gettext, so I thought > I'd revisit this and write that patch. It turns out the situation is > slightly different than I thought. So no patch, but I wanted to report > here what I found. > > It's true that the option is called NO_GETTEXT in git.git, but NO_MSGFMT > in the tcl programs we pull in. So I figured to start with a patch that > turns on NO_MSGFMT automatically when NO_GETTEXT is set. But it's > not necessary. > > The gitk and git-gui tests actually check that msgfmt is available. > If it isn't, they automatically fall back to using a pure-tcl > implementation. So there's generally no need to set NO_MSGFMT at > all. > > But that fallback is implemented using tcl. So if you _also_ don't have > tcl installed (and I don't), you get quite a confusing output from make: > > $ make -j1 > SUBDIR git-gui > MSGFMT po/pt_pt.msg Makefile:252: recipe for target 'po/pt_pt.msg' failed > make: *** [po/pt_pt.msg] Error 127 > > If you run with V=1, you can see that it's not running msgfmt at all, > but: > > tclsh po/po2msg.sh --statistics --tcl -l pt_pt -d po/ po/pt_pt.po > > So my takeaways are: > > 1. You should never need to set NO_MSGFMT; it falls back > automatically. > > 2. If you don't have gettext, you should set NO_GETTEXT to tell the > rest of git not to use it. > > 3. If you see msgfmt errors even after NO_GETTEXT, try NO_TCLTK. I wonder if something like following patch could help, as anyway the build will fail if Tcl/Tk is not installed and people often prefer builds failing at the beginning rather than towards the end. diff --git a/Makefile b/Makefile index ee9d5eb11e..9789027739 100644 --- a/Makefile +++ b/Makefile @@ -1636,6 +1636,13 @@ ifeq ($(TCLTK_PATH),) NO_TCLTK = NoThanks endif +ifndef NO_TCLTK + has_tcltk := $(shell type $(TCLTK_PATH) 2>/dev/null) + ifndef has_tcltk +$(error "Tcl/Tk is not installed ('$(TCLTK_PATH)' not found). Consider setting NO_TCLTK or installing it") + endif +endif + ifeq ($(PERL_PATH),) NO_PERL = NoThanks endif
prev parent reply other threads:[~2017-11-12 17:32 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-12 13:44 NO_MSGFMT Dominik Mahrer (Teddy) 2017-08-13 4:58 ` NO_MSGFMT Jeff King 2017-11-12 11:57 ` NO_MSGFMT Jeff King 2017-11-12 17:32 ` Christian Couder [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAP8UFD2gKTourXUdB_9_FZ3AEECTDc1Fx1NFKzeaTZDWHC3jxA@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: NO_MSGFMT' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).