From: Christian Couder <christian.couder@gmail.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Users <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Stefan Beller <sbeller@google.com>
Subject: Re: [PATCH v3 2/2] travis-ci: build documentation
Date: Wed, 4 May 2016 11:11:44 +0200 [thread overview]
Message-ID: <CAP8UFD2XXE2Hh9NxMFS3dvaJk90LgwdbDcXmHvVir6MEKu2B3Q@mail.gmail.com> (raw)
In-Reply-To: <32CC7549-3A50-42F3-A6CC-9B15EFA01A46@gmail.com>
On Wed, May 4, 2016 at 10:04 AM, Lars Schneider
<larsxschneider@gmail.com> wrote:
>
> On 03 May 2016, at 17:43, Junio C Hamano <gitster@pobox.com> wrote:
>
>> Lars Schneider <larsxschneider@gmail.com> writes:
>>
>>> On 02 May 2016, at 22:45, Junio C Hamano <gitster@pobox.com> wrote:
>>>
>>>> larsxschneider@gmail.com writes:
>>>>
>>>>> +set -e
>>>>> +
>>>>> +LINKS=$(grep --recursive --only-matching --no-filename --perl-regexp \
>>>>> + '(?<=linkgit:).*?(?=\[\d+\])' Documentation/* \
>>>>> + | sort -u \
>>>>> +)
>>>>> +
>>>>> +for LINK in $LINKS; do
>>>>> + echo "Checking linkgit:$LINK..."
>>>>> + test -s Documentation/$LINK.txt
>>>>> +done
>>>>
>>>> Please separate the above link check out of this step and do so
>>>> separately after the move of test body to a separate script
>>>> settles.
>>>
>>> OK. I also wonder if the link check should rather go to the
>>> "check-docs" Makefile target?
>>
>> That sounds like a good direction.
>>
>> Which in turn means that people on all platforms are welcome to run
>> it, which in turn means that the script must be even more portable,
>> with avoiding GNUism and bash-isms etc.
>
> OK. I am not that experienced with shell scripting and therefore it
> is hard for me to distinguish between the different shell features.
> Do you know/can you recommend the most basic shell to test/work
> with? A quick Google search told me that "dash" from Ubuntu seems
> to be a good baseline as it aims to support pretty much only POSIX [1].
You might also want to check:
http://www.shellcheck.net/
next prev parent reply other threads:[~2016-05-04 9:11 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 9:35 [PATCH v2] travis-ci: build documentation larsxschneider
2016-04-29 12:14 ` Jeff King
2016-04-29 12:21 ` Matthieu Moy
2016-04-29 14:22 ` Lars Schneider
2016-04-29 14:32 ` Jeff King
2016-04-29 17:27 ` Stefan Beller
2016-04-29 17:53 ` Matthieu Moy
2016-04-29 20:44 ` Lars Schneider
2016-04-29 21:05 ` Junio C Hamano
2016-05-02 20:20 ` [PATCH v3 0/2] " larsxschneider
2016-05-02 20:20 ` [PATCH v3 1/2] Documentation: fix linkgit references larsxschneider
2016-05-02 20:34 ` Jeff King
2016-05-03 8:30 ` Lars Schneider
2016-05-03 15:41 ` Junio C Hamano
2016-05-03 17:59 ` Jeff King
2016-05-03 17:58 ` Jeff King
2016-05-04 8:38 ` [PATCH v4 0/2] travis-ci: build documentation larsxschneider
2016-05-04 8:38 ` [PATCH v4 1/2] Documentation: fix linkgit references larsxschneider
2016-05-04 8:43 ` Lars Schneider
2016-05-04 8:57 ` Jeff King
2016-05-04 11:38 ` Ramsay Jones
2016-05-04 17:28 ` Junio C Hamano
2016-05-04 17:36 ` Junio C Hamano
2016-05-04 18:52 ` Junio C Hamano
2016-05-04 19:25 ` Jeff King
2016-05-04 19:57 ` Junio C Hamano
2016-05-04 20:06 ` Jeff King
2016-05-04 21:15 ` Junio C Hamano
2016-05-04 21:31 ` Jeff King
2016-05-04 21:34 ` Junio C Hamano
2016-05-04 21:44 ` Jeff King
2016-05-04 21:52 ` Junio C Hamano
2016-05-04 22:09 ` Jeff King
2016-05-04 22:17 ` Junio C Hamano
2016-05-04 22:27 ` Junio C Hamano
2016-05-04 23:28 ` Junio C Hamano
2016-05-04 23:41 ` Jeff King
2016-05-04 23:53 ` Jeff King
2016-05-04 21:54 ` Ævar Arnfjörð Bjarmason
2016-05-04 22:11 ` Jeff King
2016-05-04 8:38 ` [PATCH v4 2/2] travis-ci: build documentation larsxschneider
2016-05-10 17:12 ` Junio C Hamano
2016-05-13 6:26 ` Lars Schneider
2016-05-02 20:20 ` [PATCH v3 " larsxschneider
2016-05-02 20:45 ` Junio C Hamano
2016-05-03 8:12 ` Lars Schneider
2016-05-03 15:43 ` Junio C Hamano
2016-05-04 8:04 ` Lars Schneider
2016-05-04 8:18 ` Eric Wong
2016-05-04 8:19 ` Junio C Hamano
2016-05-04 9:11 ` Christian Couder [this message]
2016-05-04 11:27 ` Matthieu Moy
2016-04-29 14:40 ` [PATCH v2] " Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD2XXE2Hh9NxMFS3dvaJk90LgwdbDcXmHvVir6MEKu2B3Q@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).