From: Christian Couder <christian.couder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Apr 2017, #01; Tue, 11)
Date: Tue, 11 Apr 2017 12:12:05 +0200 [thread overview]
Message-ID: <CAP8UFD2PitxZDMm+qRrFOj+tQQsEUadOiQQjXjDnBCuHd9m21g@mail.gmail.com> (raw)
In-Reply-To: <xmqqh91vqquf.fsf@gitster.mtv.corp.google.com>
> * cc/split-index-config (2017-03-30) 1 commit
> - read-cache: avoid using git_path() in freshen_shared_index()
>
> The split-index code configuration code used an unsafe git_path()
> function without copying its result out.
>
> Needs to be explained better.
> The code looked OK, though.
In:
http://public-inbox.org/git/xmqq7f367o0s.fsf@gitster.mtv.corp.google.com/
it looked like you were ok with the explanation or you actually wanted
it to be shorter.
So should I send a shorter one? Or should I add explanation about why
git_path() is unsafe?
next prev parent reply other threads:[~2017-04-11 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 8:40 What's cooking in git.git (Apr 2017, #01; Tue, 11) Junio C Hamano
2017-04-11 10:12 ` Christian Couder [this message]
2017-04-11 22:47 ` Jonathan Nieder
2017-04-12 0:42 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD2PitxZDMm+qRrFOj+tQQsEUadOiQQjXjDnBCuHd9m21g@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).