From: Christian Couder <firstname.lastname@example.org> To: "Carlo Marcelo Arenas Belón" <email@example.com> Cc: Junio C Hamano <firstname.lastname@example.org>, git <email@example.com>, Christian Couder <firstname.lastname@example.org>, Derrick Stolee <email@example.com>, Jacob Vosmaer <firstname.lastname@example.org> Subject: Re: [PATCH] http: add custom hostname to IP address resolves Date: Mon, 9 May 2022 17:40:03 +0200 [thread overview] Message-ID: <CAP8UFD2BTmeYuVsq2AJg32qEjPXXB5oGtU1i8KK=xjZrS39eZA@mail.gmail.com> (raw) In-Reply-To: <email@example.com> On Thu, May 5, 2022 at 1:16 PM Carlo Marcelo Arenas Belón <firstname.lastname@example.org> wrote: > On Thu, May 05, 2022 at 12:48:50PM +0200, Christian Couder wrote: > > Ok with renaming and implementing it only in transport commands. I > > don't want, and I don't think it should be necessary, to invent a way > > to do the same for non cURL transports though. I think it should be Ok > > with the doc saying that the option has only been implemented for > > HTTP(S) yet and will have no effect when other transports are used. > > I think it will be better if git aborts with an error if it is used for > a transport that it doesn't support, instead of relying in the documentation, > though. This has drawbacks, as this is likely to be called through scripts or apps and the calling code would have to be a bit more complex as passing the option couldn't be done independently of the transport/URL used. Anyway until others complain, I prefer to leave it as an obscure configuration called "http.curloptResolve" and meant to help server operators as Junio says. This avoids wondering about such issues. > > If there is a simple way to do the same thing for ssh, then I might > > take a look at it later. For "file" or bundle transports, I don't > > think it makes sense, and the "git" transport is not used much in big > > hosting services where this feature is likely to be used. > > This seems definitely useful also for ssh which is also used in big > hosting services. I am not sure it is as useful for ssh. And maybe someone will take a look at implementing it if that's the case. > Ironically, I think would be even more useful for the "git" transport > specially because it doesn't have other protections to rely on that > would help prevent spoofing (like TLS), which might be also why it is > not that widely used anymore. Yeah, more secure alternatives have taken over for good.
next prev parent reply other threads:[~2022-05-09 15:41 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-02 8:36 Christian Couder 2022-05-02 19:04 ` Junio C Hamano 2022-05-04 10:07 ` Christian Couder 2022-05-04 14:34 ` Junio C Hamano 2022-05-05 10:48 ` Christian Couder 2022-05-05 11:16 ` Carlo Marcelo Arenas Belón 2022-05-09 15:40 ` Christian Couder [this message] 2022-05-04 10:46 ` [PATCH v2] http: add custom hostname to IP address resolutions Christian Couder 2022-05-05 11:21 ` Carlo Marcelo Arenas Belón 2022-05-12 8:52 ` Christian Couder 2022-05-12 16:22 ` Junio C Hamano 2022-05-12 18:57 ` Christian Couder 2022-05-09 15:38 ` [PATCH v3] " Christian Couder 2022-05-10 18:20 ` Carlo Arenas 2022-05-12 8:29 ` Christian Couder 2022-05-12 11:55 ` Carlo Arenas 2022-05-12 13:01 ` Patrick Steinhardt 2022-05-12 13:56 ` Carlo Arenas 2022-05-12 15:58 ` Junio C Hamano 2022-05-16 8:38 ` [PATCH v4] " Christian Couder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAP8UFD2BTmeYuVsq2AJg32qEjPXXB5oGtU1i8KK=xjZrS39eZA@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] http: add custom hostname to IP address resolves' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).