From: Christian Couder <christian.couder@gmail.com>
To: Jack McGuinness <jmcguinness2@ucmerced.edu>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
Jack McGuinness via GitGitGadget <gitgitgadget@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script
Date: Mon, 25 Apr 2022 11:45:57 +0200 [thread overview]
Message-ID: <CAP8UFD1aAVCgEQvi4WjCiRUBWs6_u-7k-JWTz5b1N7xa=V8OdA@mail.gmail.com> (raw)
In-Reply-To: <BYAPR06MB4517BCBBA837AA3004B2137DE6F29@BYAPR06MB4517.namprd06.prod.outlook.com>
Hi,
On Tue, Apr 19, 2022 at 8:33 AM Jack McGuinness
<jmcguinness2@ucmerced.edu> wrote:
>
> Hi, thank you for the advice. I wanted it to be that way myself, however I was using gitgitgadget to email it, and my PR was composed of three different commits, which caused it to automatically be formatted that way. I tried finding a way to remove it, but I had no luck, If you know how I would love to know!
I don't use gitgitgadget, so I cannot help you much on this. The
approach I would take if I had to use it would be to find patches on
the mailing list that were sent using gitgitgadget by experienced
developers using it, then find and see how the corresponding PRs look
like on GitHub, and try to imitate those PRs.
Anyway, it would be nice if you could try again taking into account
Junio's suggestions in:
https://lore.kernel.org/git/xmqqmtggs2nv.fsf@gitster.g/
I also have some suggestions below.
> To: Jack McGuinness via GitGitGadget; git@vger.kernel.org
> Cc: Jack McGuinness
> Subject: Re: [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script
This is your second attempt so it would be nice if it had a "v2"
marker in it like "[PATCH v2 0/3] [GSoC]" instead of "[PATCH 0/3]
[GSoC][Patch]". (Your next attempt should use "v3".)
> On 4/19/22 08:31, Jack McGuinness via GitGitGadget wrote:
> > Jack McGuinness (3):
> > [GSoC][Patch] area: t4202-log.sh, modernizing test script
> > [GSoC][Patch] area: t4202-log.sh, modernizing test script p2
> > [GSoC][Patch] area: t4202-log.sh, modernizing test script p3
Junio already commented on the "area: t4202-log.sh" part of the
subject, so I won't repeat him.
About the "modernizing test script ..." part, it would be nice if the
different patches would be a bit more specific about what each one is
doing and "p2" or "p3" is redundant with the "2/3" or "3/3" added by
GitGitGadget. For example it could be replaced with "remove whitespace
after redirect" for the second patch.
prev parent reply other threads:[~2022-04-25 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 1:31 [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script Jack McGuinness via GitGitGadget
2022-04-19 1:31 ` [PATCH 1/3] " Jack McGuinness via GitGitGadget
2022-04-19 1:31 ` [PATCH 2/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script p2 Jack McGuinness via GitGitGadget
2022-04-19 1:31 ` [PATCH 3/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script p3 Jack McGuinness via GitGitGadget
2022-04-19 5:26 ` [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script Bagas Sanjaya
2022-04-19 5:34 ` Jack McGuinness
2022-04-25 9:45 ` Christian Couder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD1aAVCgEQvi4WjCiRUBWs6_u-7k-JWTz5b1N7xa=V8OdA@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jmcguinness2@ucmerced.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).