git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [GSoC] Git Blog 7
@ 2021-07-04 14:42 ZheNing Hu
  2021-07-05 19:09 ` Christian Couder
  0 siblings, 1 reply; 2+ messages in thread
From: ZheNing Hu @ 2021-07-04 14:42 UTC (permalink / raw)
  To: Git List, Junio C Hamano, Hariom verma, Christian Couder,
	Ævar Arnfjörð Bjarmason

My seventh week blog finished:
The web version is here:
https://adlternative.github.io/GSOC-Git-Blog-7/

## Week7 Performance Testing 2

This week I used performance flame graph at the suggestion of
my mentor `Christian` to find out where my patch affected the
performance of `cat-file --batch`. `oid_object_info_extended()`
takes the largest proportion of time, accounting for `90.28%`
and `41.60%` in `cat-file --batch` and `cat-file --batch-check`
respectively. Part of the reason is that `oid_object_info_extended()`
is called twice in `get_object()` with my patch. I tried to revise its
logic (`WIP`), the performance is improved when without using
`--textconv` and `--filters`.

`Ævar Arnfjörð Bjarmason` gave me a good suggestion on
performance regression: When we use the default format of
`git cat-file --batch-check` or `git cat-file --batch`, we can
directly print the meta-data of the object without going through
the logic of `ref-filter`; When we use other format, use the
logic in ref-filter.

In addition, `Ævar Arnfjörð Bjarmason` also suggests adding a
performance test for `git cat-file --batch`, this can help us analyze
and compare performance changes later.

There are intensive exams in these two weeks, and sometimes the
response may be delayed.

Thanks.
--
ZheNing Hu

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [GSoC] Git Blog 7
  2021-07-04 14:42 [GSoC] Git Blog 7 ZheNing Hu
@ 2021-07-05 19:09 ` Christian Couder
  0 siblings, 0 replies; 2+ messages in thread
From: Christian Couder @ 2021-07-05 19:09 UTC (permalink / raw)
  To: ZheNing Hu
  Cc: Git List, Junio C Hamano, Hariom verma,
	Ævar Arnfjörð Bjarmason

On Sun, Jul 4, 2021 at 4:42 PM ZheNing Hu <adlternative@gmail.com> wrote:
>
> My seventh week blog finished:
> The web version is here:
> https://adlternative.github.io/GSOC-Git-Blog-7/

Thanks!

> ## Week7 Performance Testing 2
>
> This week I used performance flame graph at the suggestion of
> my mentor `Christian` to find out where my patch affected the
> performance of `cat-file --batch`. `oid_object_info_extended()`
> takes the largest proportion of time, accounting for `90.28%`
> and `41.60%` in `cat-file --batch` and `cat-file --batch-check`
> respectively. Part of the reason is that `oid_object_info_extended()`
> is called twice in `get_object()` with my patch. I tried to revise its
> logic (`WIP`), the performance is improved when without using

s/when without/when not/

> `--textconv` and `--filters`.
>
> `Ævar Arnfjörð Bjarmason` gave me a good suggestion on
> performance regression: When we use the default format of
> `git cat-file --batch-check` or `git cat-file --batch`, we can
> directly print the meta-data of the object without going through
> the logic of `ref-filter`; When we use other format, use the
> logic in ref-filter.
>
> In addition, `Ævar Arnfjörð Bjarmason` also suggests adding a
> performance test for `git cat-file --batch`, this can help us analyze
> and compare performance changes later.
>
> There are intensive exams in these two weeks, and sometimes the
> response may be delayed.

Ok, no worries!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-05 19:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-04 14:42 [GSoC] Git Blog 7 ZheNing Hu
2021-07-05 19:09 ` Christian Couder

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).