From: Christian Couder <christian.couder@gmail.com>
To: Drew DeVault <sir@cmpwn.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [Proposal] git am --check
Date: Mon, 3 Jun 2019 11:28:23 +0200 [thread overview]
Message-ID: <CAP8UFD1W_tB34N-uAA85+QkHY6kmGWYYM47zceP3=5aTwxwvnQ@mail.gmail.com> (raw)
In-Reply-To: <BUJFK0ZEKP5I.16DDFWUTXGJTE@homura>
On Sun, Jun 2, 2019 at 7:38 PM Drew DeVault <sir@cmpwn.com> wrote:
>
> This flag would behave similarly to git apply --check, or in other words
> would exit with a nonzero status if the patch is not applicable without
> actually applying the patch otherwise.
`git am` uses the same code as `git apply` to apply patches, so there
should be no difference between `git am --check` and `git apply
--check`.
> Rationale: I'm working on an email client which has some git
> integration, and when you scroll over a patch I want to quickly test its
> applicability and show an indication of the result.
>
> Thoughts on the approach are welcome; my initial naive patch just tried
> to add --check to the apply flags but that didn't work as I had hoped.
> Will take another crack at a patch soon(ish).
Could you tell us about what didn't work as you hoped? And how `git am
--check` would be different from `git apply --check`?
next prev parent reply other threads:[~2019-06-03 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 17:37 [Proposal] git am --check Drew DeVault
2019-06-03 9:28 ` Christian Couder [this message]
2019-06-03 9:35 ` Duy Nguyen
2019-06-03 18:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD1W_tB34N-uAA85+QkHY6kmGWYYM47zceP3=5aTwxwvnQ@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=sir@cmpwn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).