Upstreaming Reviewed-by to git.git

Upstreaming Reviewed-by to git.git

[Bagas Sanjaya]

Hi,

I had reviewing patches here, but how can my reviews be credited with
Reviewed-by tags to the applicable patches on git.git (Git SCM)
repo (upstream)?

-- 
An old man doll... just what I always wanted! - Clara

Re: Upstreaming Reviewed-by to git.git

[Christian Couder]

Hi,

On Mon, Mar 29, 2021 at 1:03 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:

> I had reviewing patches here, but how can my reviews be credited with
> Reviewed-by tags to the applicable patches on git.git (Git SCM)
> repo (upstream)?

When you have reviewed a patch or a patch series, you can tell the
reviewer you are ok with the patch or patch series, and that you are
ok with them adding your "Reviewed-by: yourname <youremail>" to it.

If you are applying to the GSoC or other such program, you can also
put links to the discussions you participated in in your proposal.

Re: Upstreaming Reviewed-by to git.git

[Junio C Hamano]

Christian Couder <christian.couder@gmail.com> writes:

> On Mon, Mar 29, 2021 at 1:03 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
>> I had reviewing patches here, but how can my reviews be credited with
>> Reviewed-by tags to the applicable patches on git.git (Git SCM)
>> repo (upstream)?
>
> When you have reviewed a patch or a patch series, you can tell the
> reviewer you are ok with the patch or patch series, and that you are
> ok with them adding your "Reviewed-by: yourname <youremail>" to it.

I think you meant "you can tell the reviewEE", not reviewer.

In general, anybody can review a patch, but a review by somebody who
is not all that familiar with the codebase does not carry a lot of
weight.  Reviews from those who have already invested a lot in the
code that is being fixed or extended would obviously be very
helpful, as they are expected to know how the current code is
supposed to work well, and reviews from those who have worked on
other parts of the system that depend on the code that is being
fixed or extended would also be usefl, as they know what the callers
of the code being changed expect out of it.

So my suggestion to Bagas is not to worry too much about
"Reviewed-by" with your name, until you have your own code in the
codebase (and while doing so, you should worry about adding
reviewed-by by others).

In any case, reading others' patch, together with the original
version before the patch changed, is a great opportunity to learn
the codebase and how the project work in general.  It is highly
recommended.

Thanks.

Re: Upstreaming Reviewed-by to git.git

[Junio C Hamano]

Junio C Hamano <gitster@pobox.com> writes:

> In any case, reading others' patch, together with the original
> version before the patch changed, is a great opportunity to learn
> the codebase and how the project work in general.  It is highly
> recommended.

Addendum.  The above makes it sound as if I am encouraging new
people to only read to learn silently, but that is not what I meant.

Reading and then expressing what you read in the patch in your own
words is a good way for you to learn the system.  And it is also a
good way for the patch author to ensure what was written in the
patch is understandable.  For somebody who is totally new to the
codebase, any patch that is more complex than the most trivial might
not be hard to understand and that is not a patch author's fault,
but once contributors have learned the codebase enough, even before
they have their own changes to our codebase, a new patch should be
written in such a way to understandable by them without getting
misunderstood.  So a mere "this looks good to me" by new people may
not add much value to the discussion, but thinking aloud in more
detail, expressing why they think the patch is good, e.g. "I think
this change tries to do X by doing Y.  If I were doing so, I might
do so by Z, but I think Y would be a better approach than that"
would help others to see that what is written in the patch was truly
understandable (if what the new person said was to the point) or
misleading (otherwise).

Thanks.

Re: Upstreaming Reviewed-by to git.git

[Christian Couder]

On Mon, Mar 29, 2021 at 11:03 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Christian Couder <christian.couder@gmail.com> writes:
>
> > On Mon, Mar 29, 2021 at 1:03 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> >
> >> I had reviewing patches here, but how can my reviews be credited with
> >> Reviewed-by tags to the applicable patches on git.git (Git SCM)
> >> repo (upstream)?
> >
> > When you have reviewed a patch or a patch series, you can tell the
> > reviewer you are ok with the patch or patch series, and that you are
> > ok with them adding your "Reviewed-by: yourname <youremail>" to it.
>
> I think you meant "you can tell the reviewEE", not reviewer.

Yeah, sorry and thanks for all your explanations.