From: Christian Couder <christian.couder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Aug 2018, #04; Fri, 17)
Date: Sat, 18 Aug 2018 11:34:29 +0200 [thread overview]
Message-ID: <CAP8UFD1BOqGER4-gnv8VQfsRbZ3yYFEx-ScL3s_WfoKgV=rk6A@mail.gmail.com> (raw)
In-Reply-To: <xmqqva88aa0c.fsf@gitster-ct.c.googlers.com>
On Sat, Aug 18, 2018 at 12:44 AM Junio C Hamano <gitster@pobox.com> wrote:
> * cc/delta-islands (2018-08-16) 7 commits
> - pack-objects: move 'layer' into 'struct packing_data'
> - pack-objects: move tree_depth into 'struct packing_data'
> - t5320: tests for delta islands
> - repack: add delta-islands support
> - pack-objects: add delta-islands support
> - pack-objects: refactor code into compute_layer_order()
> - Add delta-islands.{c,h}
>
> Lift code from GitHub to restrict delta computation so that an
> object that exists in one fork is not made into a delta against
> another object that does not appear in the same forked repository.
>
> What's the doneness of this topic?
All the suggestions by Peff, you, Duy, Dscho, Ramsay and Szeder Gabor
have been taken into account in the v5 that is in pu.
Except the suggestion by Duy to move 2 fields from 'struct
object_entry' to 'struct packing_data' (which is implemented in
patches 6/7 and 7/7) the suggestions have all been about relatively
small things (documentation, code modernization, regex check,
translation strings, ...) So the code is very similar to the original
code in https://github.com/peff/git/commits/jk/delta-islands which has
been used for years by GitHub in production.
FYI this has been requested from GitLab by Drupal (as well as others)
see https://www.drupal.org/drupalorg/blog/developer-tools-initiative-part-5-gitlab-partnership
which contains:
"The timeline for Phase 2 is dependent on GitLab’s resolution of a
diskspace deduplication issue, which they have committed to on our
behalf: https://gitlab.com/gitlab-org/gitlab-ce/issues/23029"
next prev parent reply other threads:[~2018-08-18 9:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 22:44 What's cooking in git.git (Aug 2018, #04; Fri, 17) Junio C Hamano
2018-08-18 6:29 ` Duy Nguyen
2018-08-18 6:59 ` Jonathan Nieder
2018-08-20 17:26 ` Junio C Hamano
2018-08-20 18:14 ` Derrick Stolee
2018-08-18 9:34 ` Christian Couder [this message]
2018-08-18 11:34 ` Ævar Arnfjörð Bjarmason
2018-08-18 12:54 ` Christian Couder
2018-08-18 11:10 ` Ævar Arnfjörð Bjarmason
2018-08-20 10:23 ` Phillip Wood
2018-08-20 17:44 ` Eric Sunshine
2018-08-20 19:36 ` pw/rebase-i-author-script-fix, was " Johannes Schindelin
2018-08-20 18:11 ` Stefan Beller
2018-08-20 21:32 ` Junio C Hamano
2018-08-20 18:19 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD1BOqGER4-gnv8VQfsRbZ3yYFEx-ScL3s_WfoKgV=rk6A@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).