From: Christian Couder <christian.couder@gmail.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Git Mailing list <git@vger.kernel.org>
Subject: Re: "git bisect" takes exactly one bad commit and one or more good?
Date: Sat, 11 Nov 2017 13:01:43 +0100 [thread overview]
Message-ID: <CAP8UFD1=idL51XDzE_RKc_7z9NghTd7GHoZ-T61y0rQ8ZYXomw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1711110612290.5087@localhost.localdomain>
On Sat, Nov 11, 2017 at 12:22 PM, Robert P. J. Day
<rpjday@crashcourse.ca> wrote:
>
> more on "git bisect" ... the man page seems to make it clear that
> bisection takes *precisely* one "bad" commit, and one *or more* good
> commits, is that correct?
Yeah, that's true.
> seems that way, given the ellipses in the
> commands below:
>
> git bisect start [--term-{old,good}=<term> --term-{new,bad}=<term>]
> [--no-checkout] [<bad> [<good>...]] [--] [<paths>...]
> git bisect (bad|new|<term-new>) [<rev>]
> git bisect (good|old|<term-old>) [<rev>...]
Yeah indeed.
> however, other parts of the man page seem less clear. just below
> that, a description that bisection takes "a" good commit:
>
> "You use it by first telling it a "bad" commit that is known to
> contain the bug, and a "good" commit that is known to be before the
> bug was introduced."
Yeah, 'and at least a "good" commit' would be better.
> and a bit lower, we read "at least one bad ...", which some people
> might interpret as one or more *bad* commits:
>
> "Once you have specified at least one bad and one good commit, git
> bisect selects a commit in the middle of that range of history, checks
> it out, and outputs something similar to the following:"
Yeah, 'Once you have specified one bad and at least one good commit'
would be better.
> if the rules are exactly one bad commit and one or more good, i'll
> submit a patch to reword at least the above, and possibly more if
> necessary.
Sure, thanks,
Christian.
next prev parent reply other threads:[~2017-11-11 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 11:22 "git bisect" takes exactly one bad commit and one or more good? Robert P. J. Day
2017-11-11 12:01 ` Christian Couder [this message]
2017-11-11 14:34 ` Junio C Hamano
2017-11-11 15:27 ` Robert P. J. Day
2017-11-12 12:14 ` Kaartic Sivaraam
2017-11-11 16:03 ` Robert P. J. Day
2017-11-12 21:13 ` Stephan Beyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD1=idL51XDzE_RKc_7z9NghTd7GHoZ-T61y0rQ8ZYXomw@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).