From: Christian Couder <christian.couder@gmail.com>
To: "Manuel Bärenz" <manuel@enigmage.de>
Cc: git <git@vger.kernel.org>
Subject: Re: Feature request: Exponential search in git bisect
Date: Sat, 10 Oct 2020 11:46:44 +0200 [thread overview]
Message-ID: <CAP8UFD16WX-HE6TW2Q15a3us8UMaogPpR+0C8shiEdP3-Cba=Q@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD2dWrUXJUuiFtgCu6krbnbGGqJZ7K+6KqstGTcNmSc_xQ@mail.gmail.com>
On Sat, Oct 10, 2020 at 11:22 AM Christian Couder
<christian.couder@gmail.com> wrote:
>
> On Fri, Oct 9, 2020 at 9:35 PM Manuel Bärenz <manuel@enigmage.de> wrote:
> > That's problematic because then I might accidentally mark a
> > commit as good that was already untestable bad. Given that bisect has no
> > undo functionality, that can quickly mess up my search. Distinguishing
> > untestable good from untestable bad is really hard automatically. I
> > shouldn't have to do that.
>
> Sometimes it's not very difficult to test if the feature has been
> implemented yet or not. For example with Git you could check if an
> option for a command has been implemented by just checking if it
> appears in the doc. So the bisection script could first check that and
> exit 0 (which means good) if the option doesn't appear in the doc. If
> it appears in the doc, then it could do the regular test: "skip" if
> untestable, "good" if there is no bug, "bad" otherwise.
Also note that it might actually be simpler in many cases to find when
a feature has been implemented by different means than some checks in
the script.
For example in the above example to find using the documentation when
an option for a Git command has been implemented, one could use:
git log --reverse -S'--option' Documentation/git-command.txt
It could also work by using `git log --reverse -S...` to find when
some functions or variables related to the feature appeared in the
code itself.
next prev parent reply other threads:[~2020-10-10 22:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 12:56 Feature request: Exponential search in git bisect Manuel Bärenz
2020-10-10 9:22 ` Christian Couder
2020-10-10 9:46 ` Christian Couder [this message]
2020-10-25 17:15 ` Philip Oakley
2020-10-26 18:13 ` Junio C Hamano
2020-10-26 20:59 ` Philip Oakley
2020-11-01 20:17 ` Manuel Bärenz
2020-10-27 12:10 ` Ævar Arnfjörð Bjarmason
2020-11-01 20:30 ` Manuel Bärenz
2020-11-02 10:36 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD16WX-HE6TW2Q15a3us8UMaogPpR+0C8shiEdP3-Cba=Q@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=manuel@enigmage.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).