From: Christian Couder <christian.couder@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Stefan Beller <sbeller@google.com>, git <git@vger.kernel.org>
Subject: Re: [RFC PATCH] help: add optional instructions for reporting bugs
Date: Fri, 10 Mar 2017 22:50:50 +0100 [thread overview]
Message-ID: <CAP8UFD0xCCcmd66ChsfxPBFohekucBx3ib4Ayi+KQOXNZFHMjQ@mail.gmail.com> (raw)
In-Reply-To: <20170310181342.GE26789@aiede.mtv.corp.google.com>
On Fri, Mar 10, 2017 at 7:13 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Hi,
>
> Stefan Beller wrote:
>
>> When reporting bugs, users will usually look at the output of
>> 'git --version' at one point to write a quality bug report.
>> So that is a good spot to provide additional information to the user
>> about e.g. additional the organizational quirks how to report a bug.
>>
>> As the output of 'git --version' is parsed by scripts as well,
>> we only want to present this information to users, which is why
>> we only give the output to TTYs.
>
> Interesting thought. This might also be a good place to point users
> to "git version --build-options" to get more detailed build
> information.
It looks like there is no documentation for `git version` which is a
bit unfortunate.
Also `git version -h` ignores the -h option so we cannot know that
--build-options exists.
> The existence of that option also suggests you're on the right track
> about 'git version' being the command for this.
I agree, but I don't think --build-options is the best for that.
>> Git is distributed in various ways by various organizations. The Git
>> community prefers to have bugs reported on the mailing list, whereas
>> other organizations may rather want to have filed a bug in a bug tracker
>> or such. The point of contact is different by organization as well.
>
> It's tempting to put the custom information in --build-options --- e.g.
>
> $ git version
> git version 2.12.0.190.g6e60aba09d.dirty
> hint: use "git version --build-options" for more detail
> hint: and bug reporting instructions
> $
> $ git version --build-options
> git version 2.12.0.190.g6e60aba09d.dirty
> sizeof-long: 8
> reporting-bugs: see REPORTING BUGS section in "git help git"
I don't think it's a good idea to add those "hint: ..." and
"reporting-bugs: ..." lines.
I think it's better to do things like the following:
- add `git version -h`
- add proper documentation for `git version` so that `git help version` works
- in `git help version` talk about the REPORTING BUGS section in `git help git`
- add `git version --full` or other such options to also print other
stuff like the current OS, processor architecture, libc, etc
- suggest in `git help version` and/or in the REPORTING BUGS section
in `git help git` that people just copy paste the output of `git
version --full` in their bug report
[...]
> I'm still on the fence about whether this is a good idea. At least
> having custom bug instructions in --build-options sounds like a very
> nice thing, but it's not obvious to me how people would learn about
> that option.
Yeah indeed.
Thanks,
Christian.
next prev parent reply other threads:[~2017-03-10 21:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 19:30 [RFC PATCH] help: add optional instructions for reporting bugs Stefan Beller
2017-03-10 18:13 ` Jonathan Nieder
2017-03-10 21:50 ` Christian Couder [this message]
2017-03-12 12:47 ` Jeff King
2017-03-13 18:00 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD0xCCcmd66ChsfxPBFohekucBx3ib4Ayi+KQOXNZFHMjQ@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).