From: Christian Couder <christian.couder@gmail.com>
To: Harald Nordgren <haraldnordgren@gmail.com>
Cc: git <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Tiago Botelho <tiago@gitlab.com>,
Stefan Beller <sbeller@google.com>
Subject: Re: [PATCH v2] Make it possible to implement bisecting only on first parents or on merge commits by passing flags to find_bisection(), instead of just a find_all boolean
Date: Sun, 15 Apr 2018 15:35:48 +0200 [thread overview]
Message-ID: <CAP8UFD0gwLZ8NzpRKb3qz=QkKbTNLjwBVnEd0QGCxAGtCDo=Xg@mail.gmail.com> (raw)
In-Reply-To: <20180415104438.2046-1-haraldnordgren@gmail.com>
On Sun, Apr 15, 2018 at 12:44 PM, Harald Nordgren
<haraldnordgren@gmail.com> wrote:
> Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
> ---
>
> Notes:
> Updates according to Christian Couder's code review
About the commit message (its first line and its body), I was
suggesting a patch like the following:
From 3a0ced0953ccc6038a43885d98a507eb18c19e42 Mon Sep 17 00:00:00 2001
From: Harald Nordgren <haraldnordgren@gmail.com>
Date: Sun, 15 Apr 2018 12:44:38 +0200
Subject: [PATCH] bisect: create 'bisect_flags' parameter in find_bisection()
Make it possible to implement bisecting only on first parents or on
merge commits by passing flags to find_bisection(), instead of just
a 'find_all' boolean.
Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
---
bisect.c | 20 ++++++++++++--------
bisect.h | 6 ++++--
builtin/rev-list.c | 6 +++---
3 files changed, 19 insertions(+), 13 deletions(-)
...
The rest of the patch looks good to me.
Thanks!
next prev parent reply other threads:[~2018-04-15 13:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-15 8:58 [PATCH] Create 'bisect_flags' parameter in find_bisection() in preparation of passing multiple options Harald Nordgren
2018-04-15 9:55 ` Christian Couder
2018-04-15 10:44 ` [PATCH v2] Make it possible to implement bisecting only on first parents or on merge commits by passing flags to find_bisection(), instead of just a find_all boolean Harald Nordgren
2018-04-15 13:35 ` Christian Couder [this message]
2018-04-15 13:49 ` [PATCH v3] bisect: create 'bisect_flags' parameter in find_bisection() Harald Nordgren
2018-04-17 2:15 ` Junio C Hamano
2018-04-18 20:31 ` Johannes Schindelin
2018-04-18 21:05 ` [PATCH v4] " Harald Nordgren
2018-04-20 12:23 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD0gwLZ8NzpRKb3qz=QkKbTNLjwBVnEd0QGCxAGtCDo=Xg@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=haraldnordgren@gmail.com \
--cc=sbeller@google.com \
--cc=tiago@gitlab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).