git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Christian Couder <christian.couder@gmail.com>
To: Jeff King <peff@peff.net>, Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Christian Couder <chriscool@tuxfamily.org>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: function get_delta_base() is a file-local symbol
Date: Sun, 12 Aug 2018 05:53:54 +0200	[thread overview]
Message-ID: <CAP8UFD0KtVWtyAp1sBoLLCE5L5u6qH0VQ6Ng12Bopv+28Nnk1A@mail.gmail.com> (raw)
In-Reply-To: <20180812011612.GA10782@sigill.intra.peff.net>

Hi Ramsay and Peff,

On Sun, Aug 12, 2018 at 3:16 AM, Jeff King <peff@peff.net> wrote:
> On Sun, Aug 12, 2018 at 01:30:02AM +0100, Ramsay Jones wrote:
>
>> My static-check.pl script has pinged me about the get_delta_base()
>> symbol from packfile.[co]. The first patch from your 'cc/delta-islands'
>> branch exports this symbol, saying that it will soon be called from
>> outside packfile.c. As far as I can tell, no other patch in that series
>> adds any such call.

Yeah, I should have checked that but I didn't.

Thanks for noticing.

>> Do you have plans to extend that series with additional patches which
>> will add such calls?
>
> Hmm, I think this is just my error. I had to untangle the delta island
> code from a few other topics, and I think I mistakenly attributed the
> need for get_delta_base() to the wrong topic. It can just be left alone
> for this series.

Ok, I will will remove the first patch in the next reroll. Thanks.

      reply	other threads:[~2018-08-12  3:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-12  0:30 function get_delta_base() is a file-local symbol Ramsay Jones
2018-08-12  1:16 ` Jeff King
2018-08-12  3:53   ` Christian Couder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP8UFD0KtVWtyAp1sBoLLCE5L5u6qH0VQ6Ng12Bopv+28Nnk1A@mail.gmail.com \
    --to=christian.couder@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).