From: Christian Couder <christian.couder@gmail.com>
To: Miriam Rubio <mirucam@gmail.com>
Cc: git <git@vger.kernel.org>, Pranit Bauva <pranit.bauva@gmail.com>,
Lars Schneider <larsxschneider@gmail.com>,
Christian Couder <chriscool@tuxfamily.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Tanushree Tumane <tanushreetumane@gmail.com>
Subject: Re: [PATCH v4 3/7] bisect--helper: retire `--bisect-write` subcommand
Date: Fri, 29 Jan 2021 08:54:23 +0100 [thread overview]
Message-ID: <CAP8UFD07Ajht9nj3ykYMGW6FnhrScKGBKuTpJMABVvVKuKx9gg@mail.gmail.com> (raw)
In-Reply-To: <20210125191710.45161-4-mirucam@gmail.com>
On Mon, Jan 25, 2021 at 8:17 PM Miriam Rubio <mirucam@gmail.com> wrote:
> @@ -1048,11 +1044,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
> if (argc > 1)
> return error(_("--bisect-reset requires either no argument or a commit"));
> return !!bisect_reset(argc ? argv[0] : NULL);
Here we are returning so we never fall back into the BISECT_WRITE case below...
> - case BISECT_WRITE:
> - if (argc != 4 && argc != 5)
> - return error(_("--bisect-write requires either 4 or 5 arguments"));
> - set_terms(&terms, argv[3], argv[2]);
> - res = bisect_write(argv[0], argv[1], &terms, nolog);
> break;
...so the above "break;" could be removed too.
> case CHECK_AND_SET_TERMS:
> if (argc != 3)
next prev parent reply other threads:[~2021-01-29 7:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 19:17 [PATCH v4 0/7] Finish converting git bisect to C part 3 Miriam Rubio
2021-01-25 19:17 ` [PATCH v4 1/7] bisect--helper: reimplement `bisect_log` shell function in C Miriam Rubio
2021-01-30 1:46 ` Đoàn Trần Công Danh
2021-01-30 9:49 ` Christian Couder
2021-01-25 19:17 ` [PATCH v4 2/7] bisect--helper: reimplement `bisect_replay` " Miriam Rubio
2021-01-29 7:51 ` Christian Couder
2021-01-25 19:17 ` [PATCH v4 3/7] bisect--helper: retire `--bisect-write` subcommand Miriam Rubio
2021-01-29 7:54 ` Christian Couder [this message]
2021-01-25 19:17 ` [PATCH v4 4/7] bisect--helper: use `res` instead of return in BISECT_RESET case option Miriam Rubio
2021-01-29 7:57 ` Christian Couder
2021-01-25 19:17 ` [PATCH v4 5/7] bisect--helper: retire `--bisect-auto-next` subcommand Miriam Rubio
2021-01-25 19:17 ` [PATCH v4 6/7] bisect--helper: reimplement `bisect_skip` shell function in C Miriam Rubio
2021-01-25 19:17 ` [PATCH v4 7/7] bisect--helper: retire `--check-and-set-terms` subcommand Miriam Rubio
2021-01-29 0:49 ` Junio C Hamano
2021-01-26 17:55 ` [PATCH v4 0/7] Finish converting git bisect to C part 3 Junio C Hamano
2021-01-26 18:27 ` Miriam R.
2021-01-26 20:05 ` Junio C Hamano
2021-01-26 22:32 ` Junio C Hamano
2021-01-27 14:12 ` Miriam R.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD07Ajht9nj3ykYMGW6FnhrScKGBKuTpJMABVvVKuKx9gg@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=mirucam@gmail.com \
--cc=pranit.bauva@gmail.com \
--cc=tanushreetumane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).