From: Ben Walton <bdwalton@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
"Johannes Sixt" <j6t@kdbg.org>, git <git@vger.kernel.org>,
"Ævar Arnfjörð" <avarab@gmail.com>
Subject: Re: [PATCH] Avoid difference in tr semantics between System V and BSD
Date: Mon, 28 Oct 2013 21:12:10 +0000 [thread overview]
Message-ID: <CAP30j17Qv7DrrbgZTsCQB8gxsfQTfVy35s9sDkW0=pHz9F+W3Q@mail.gmail.com> (raw)
In-Reply-To: <CAP30j179XPZqTGiZuvyZEL94Q14ocas+r8mP_R4gLetWwikkwA@mail.gmail.com>
On Mon, Oct 28, 2013 at 9:04 PM, Ben Walton <bdwalton@gmail.com> wrote:
> I'm happy to defer to your judgement on this - If you'd like the tests
> wrapped, I'll do so.
>
> Thanks
> -Ben
>
> On Mon, Oct 28, 2013 at 7:08 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Jonathan Nieder <jrnieder@gmail.com> writes:
>>
>>> Johannes Sixt wrote:
>>>
>>>> In other tests, we check for prerequisite PERL, i.e., we are prepared
>>>> that perl is not available. Shouldn't we do that here, too?
>>>
>>> I think the tests assume there's a perl present even when the PERL
>>> prereq isn't present already. E.g.:
>>>
>>> nul_to_q () {
>>> "$PERL_PATH" -pe 'y/\000/Q/'
>>> }
>>>
>>> So in practice the PERL prereq just means "NO_PERL wasn't set", or
>>> in other words, "commands that use perl work". Maybe something
>>> like the following would help?
>>>
>>> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
>>>
>>> diff --git i/t/README w/t/README
>>> index 2167125..54cd064 100644
>>> --- i/t/README
>>> +++ w/t/README
>>> @@ -629,11 +629,20 @@ See the prereq argument to the test_* functions in the "Test harness
>>> library" section above and the "test_have_prereq" function for how to
>>> use these, and "test_set_prereq" for how to define your own.
>>>
>>> - - PERL & PYTHON
>>> + - PYTHON
>>>
>>> - Git wasn't compiled with NO_PERL=YesPlease or
>>> - NO_PYTHON=YesPlease. Wrap any tests that need Perl or Python in
>>> - these.
>>> + Git wasn't compiled with NO_PYTHON=YesPlease. Wrap any tests that
>>> + need Python with this.
>>> +
>>> + - PERL
>>> +
>>> + Git wasn't compiled with NO_PERL=YesPlease.
>>> +
>>> + Even without the PERL prerequisite, tests can assume there is a
>>> + usable perl interpreter at $PERL_PATH, though it need not be
>>> + particularly modern.
>>> +
>>> + Wrap tests for commands implemented in Perl with this.
>>
>> Sounds like a sensible thing to address, but I first parsed it as
>>
>> Wrap (tests for (commands implemented in Perl)) with this.
>>
>> while I think the readers are expected to parse it as
>>
>> Wrap ((tests for commands) implemented in Perl) with this.
>>
Per the other discussion about replacing all PERL_PATH with a shell
function named perl, should I update this patch to use $PERL_PATH in
the meantime so that it can be batch updated when the function is
added in a separate patch?
Thanks
-Ben
--
---------------------------------------------------------------------------------------------------------------------------
Take the risk of thinking for yourself. Much more happiness,
truth, beauty and wisdom will come to you that way.
-Christopher Hitchens
---------------------------------------------------------------------------------------------------------------------------
next prev parent reply other threads:[~2013-10-28 21:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 21:17 [PATCH] Avoid broken Solaris tr Ben Walton
2013-06-18 22:31 ` Junio C Hamano
2013-10-28 9:02 ` Ben Walton
2013-10-28 9:13 ` [PATCH] Avoid difference in tr semantics between System V and BSD Ben Walton
2013-10-28 18:07 ` Johannes Sixt
2013-10-28 18:27 ` Jonathan Nieder
2013-10-28 19:08 ` Junio C Hamano
2013-10-28 19:22 ` [PATCH] t/README: tests can use perl even with NO_PERL Jonathan Nieder
2013-10-28 19:46 ` Johannes Sixt
2013-10-28 19:54 ` Jeff King
2013-10-28 21:04 ` Jonathan Nieder
2013-10-28 21:43 ` Ben Walton
2013-10-29 1:18 ` [RFC/PATCH 0/3] perl Jeff King
2013-10-29 1:19 ` [PATCH 1/3] use @@PERL@@ in built scripts Jeff King
2013-10-29 19:41 ` Junio C Hamano
2013-10-29 1:22 ` [PATCH 2/3] t: provide a perl() function which uses $PERL_PATH Jeff King
2013-10-29 1:23 ` [PATCH 3/3] t: use perl instead of "$PERL_PATH" where applicable Jeff King
2013-10-28 21:04 ` [PATCH] Avoid difference in tr semantics between System V and BSD Ben Walton
2013-10-28 21:12 ` Ben Walton [this message]
2013-10-28 21:30 ` Junio C Hamano
2013-10-28 21:40 ` Ben Walton
2013-10-28 21:43 ` Ben Walton
2013-10-28 21:43 ` Ben Walton
2013-10-30 17:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP30j17Qv7DrrbgZTsCQB8gxsfQTfVy35s9sDkW0=pHz9F+W3Q@mail.gmail.com' \
--to=bdwalton@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).