From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id B8AF01F466 for ; Mon, 27 Jan 2020 13:58:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728783AbgA0N6F (ORCPT ); Mon, 27 Jan 2020 08:58:05 -0500 Received: from lb3-smtp-cloud8.xs4all.net ([194.109.24.29]:46653 "EHLO lb3-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbgA0N6F (ORCPT ); Mon, 27 Jan 2020 08:58:05 -0500 Received: from mail-ot1-f42.google.com ([209.85.210.42]) by smtp-cloud8.xs4all.net with ESMTPSA id w4tripK4GpLtbw4tvijiba; Mon, 27 Jan 2020 14:58:03 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s1; t=1580133483; bh=DLsRXR7GihjNHSCyMc4tUdsWWZqQRkHGIlgEyToxTa8=; h=MIME-Version:From:Date:Message-ID:Subject:To:Content-Type:From: Subject; b=s/eHvztWyxfu4NplEtmiXb2QSIDwnQyrEjClnReVTbpmMkew9i1kpwKE5MneSHEvO CY3U5k60UeOnqUGO/9H3PNJFPzfVThCawPM9vtI5oAOxNJ8Yeh4isBODo4MUKoihBD 4FCbE2L7KlR6N53EWkHsS5oGpDMn8rR1pjW7QhrRZi7okQDT19WBrTJNq5BoUnt7d9 geCLmnsE4aspbIV5h8SjD4Ac4dHTlC9CrBUeR6xnoy9Cnv+mNvbUucK61iex0F2Emo 70tBfqQx68DIE7OkuFs36toj7KPBU6F+mbhK1NFm5O8gZTq/q+12+O3trmxefs3TEL zWiEc7kDQtXDw== Received: by mail-ot1-f42.google.com with SMTP id r27so8389117otc.8 for ; Mon, 27 Jan 2020 05:58:02 -0800 (PST) X-Gm-Message-State: APjAAAX+y633czZsxzxRERcmoSNSTZtGicy9gsBtsTP3S51mD+xTjPm9 oG3C1SGvvnnqWBusXy1tnalAc7R/LGHO1fnVaZs= X-Google-Smtp-Source: APXvYqybHTQu7EICKbu4R2GxyhUfg/Ra9m53u54ELH6KsfIbfY09bwk6L8Sv1Z3fbaVJ2BqHRPlEed2FfpLtVoKE5KI= X-Received: by 2002:a05:6830:2111:: with SMTP id i17mr11837712otc.24.1580133479232; Mon, 27 Jan 2020 05:57:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Reply-To: hanwenn@gmail.com From: Han-Wen Nienhuys Date: Mon, 27 Jan 2020 14:57:48 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/5] Reftable support git-core To: Junio C Hamano Cc: Han-Wen Nienhuys via GitGitGadget , git@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-CMAE-Envelope: MS4wfJuRUnN8XQr0eT3kQnV32wwy+ikZ5zeSI5WKN7cq+0STLWdoykbcMR+4dkS0XVZ033+Fy0XujNSH50p9yocTI85U8e/JASyJtFu8zbYvAO9Gwp3vMo07 M9aFgUt02XObUMyvDFy5SKJzdnd44oEk3HDpNnpWso2v3vk0lAqK4ua5JMdpkkfRUxgRPM8ccosHEQ== Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Jan 27, 2020 at 2:52 PM Han-Wen Nienhuys wrote: > > * Mixed indentation and many whitespace breakages make the code > > distracting to review. > > Do you mean in the changes to refs/reftable-backend.c? Or the imported code? > > The imported code is uniformly formatted with clang-format. > > Is there a clang-format setting for uniformly formatting to Linux/Git > style? I really love automated formatting, so we don't have to spend > time debating irrelevant details. Ah, there is a .clang-format entry in the git repository already. Thanks!