From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id B64421F466 for ; Mon, 27 Jan 2020 13:53:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728899AbgA0NxI (ORCPT ); Mon, 27 Jan 2020 08:53:08 -0500 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:39485 "EHLO lb3-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbgA0NxI (ORCPT ); Mon, 27 Jan 2020 08:53:08 -0500 Received: from mail-oi1-f170.google.com ([209.85.167.170]) by smtp-cloud9.xs4all.net with ESMTPSA id w4p4iLYf3T6sRw4p8i8EKX; Mon, 27 Jan 2020 14:53:06 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s1; t=1580133186; bh=dJhfqijYXOL+5rygYcgBZrfTarKr8h+kZ6l22ZVbpf8=; h=MIME-Version:From:Date:Message-ID:Subject:To:Content-Type:From: Subject; b=k/MkL9tZMfpLMnZba+MOdyr4SUxh/NwKpPRa6WfP0cqgHqWFoxQ0EGnyh1VPzKnSV mNG9Fjwlh/1g0eHdZTwyFZ9svdidJalJo33Clrfxk9Cx5ms8N4hIS2xd7ut4MDYe/L bjaKBgKl5PUxd/zsji49p1okyy+Hrt6N9FssFFmex1tyXVswYo5lCmjpca8lR1G3Mf SzN21Cyw1HEnaASv9888eWcfOeNxrlywgKih3mwQ4KtI9RlAQ/IVep3wvtrwbhJ9Qs C+b2opojHKe31p8HZTcF1W9S2KsK3EnP0RU+jAcrJXIrmom/YT0QPowLALrWKyu8LQ 0ti4H2TBRYpRA== Received: by mail-oi1-f170.google.com with SMTP id p125so6657560oif.10 for ; Mon, 27 Jan 2020 05:53:06 -0800 (PST) X-Gm-Message-State: APjAAAXY4asY4ikKWUeNZuAd0han/87KPWY0mpFUBlombkLVVGW2LwzK LsEiYJ8a28oEarhhGHlsG0lpKbf4YYD5RMePsbg= X-Google-Smtp-Source: APXvYqwI4BgmfiOwFz0W5WJna+kUVy2Ov6yLqqk9WrBknd7J/2CxinFP/K8T4TwjPGkiVxHlAK4j1mBhXt+DiFx+lPM= X-Received: by 2002:aca:5795:: with SMTP id l143mr4731078oib.27.1580133182612; Mon, 27 Jan 2020 05:53:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Reply-To: hanwenn@gmail.com From: Han-Wen Nienhuys Date: Mon, 27 Jan 2020 14:52:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/5] Reftable support git-core To: Junio C Hamano Cc: Han-Wen Nienhuys via GitGitGadget , git@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-CMAE-Envelope: MS4wfNApmtif4p+qFNZz/49Me0CF4F2g6ahxiCW7UC/0rKUsxSH/6CQG0myvMbGhbQhm13SNRSMyee1jvN05qZ5nKDGkDkeM2z1M9m5q5pBDJW/P2jzc402I 5hhEbr5duGqNJ0aC8VbXqe8GUkEFwyIllPsAuXLroKDilB2bU80KjuxTQDvTwRiuLqBpB6F3VW7PQw== Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jan 23, 2020 at 10:44 PM Junio C Hamano wrote: > > This adds the reftable library, and hooks it up as a ref backend. > > Just a quick impression before getting into details of individual > steps. > > * With this series, the reftable backend seems to take over as the > default and only backend. We would need to design and decide how > repositories would specify which backend it uses (I personally do > not think we need to allow more than one backend to be active at > the same time) before we take this series out of RFC status. Yes, obviously. Would you have concrete ideas on how this should work? > * What's reftable/VERSION file? Does it really have what you > intended to add? Fixed, and explained in reftable/VERSION. > * Mixed indentation and many whitespace breakages make the code > distracting to review. Do you mean in the changes to refs/reftable-backend.c? Or the imported code? The imported code is uniformly formatted with clang-format. Is there a clang-format setting for uniformly formatting to Linux/Git style? I really love automated formatting, so we don't have to spend time debating irrelevant details. > > * Comparison with 0 is written as "if (!strcmp(a, b))" in this > codebase, and never "if (0 != strcmp(a, b))". > > * We unfortunately do not use var defn "for (int i = 0; ..." yet. > > * We do not use // comments. > fixed.