From: Adam Spiers <git@adamspiers.org>
To: Git Mailing List <git@vger.kernel.org>
Subject: Bug in git citool when staging symlink as replacement for submodule
Date: Fri, 1 Jun 2012 11:31:26 +0100 [thread overview]
Message-ID: <CAOkDyE9q1n=oLoEXXxurDjNM0B2+cZ9eoeGE57F9hEQUjK0hZg@mail.gmail.com> (raw)
I found some strange behaviour in git citool when trying to stage a
symlink into the index as a replacement for a (non-registered) submodule.
I just reproduced with latest master (1.7.11.rc0.55.gb2478aa):
mkdir repo
cd repo
git init
echo foo > one
git add one
git commit -m'first commit'
mkdir two
cd two
git init
echo foo > submodule-file
git add submodule-file
git commit -m'first submodule commit'
cd ..
git add two
git commit -m'second commit'
rm -rf two
ln -s one two
git citool
At this point, git citool outputs:
error: Unhandled submodule diff marker: {@@ }
error: Unhandled submodule diff marker: {+on}
Now if I press Control-T to try to stage 'two' into the index, I get a new
dialog which says:
Updating the Git index failed. A rescan will be automatically
started to resynchronize git-gui.
error: two is already a gitlink, not replacing
fatal: Unable to process path two
[Unlock Index] [Continue]
I can work around via 'git add two', but it would be nice if citool
handled this correctly.
Thanks!
Adam
next reply other threads:[~2012-06-01 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 10:31 Adam Spiers [this message]
2012-06-09 13:47 ` [PATCH] git-gui: recognize submodule diff when replaced by file Heiko Voigt
2012-06-09 14:27 ` [PATCH] update-index: allow overwriting existing submodule index entries Heiko Voigt
2012-06-11 15:03 ` Junio C Hamano
2012-06-11 21:23 ` Jens Lehmann
2012-06-12 20:33 ` Heiko Voigt
2012-06-12 21:18 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOkDyE9q1n=oLoEXXxurDjNM0B2+cZ9eoeGE57F9hEQUjK0hZg@mail.gmail.com' \
--to=git@adamspiers.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).