From: Matt Rogers <mattr94@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Matthew Rogers via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
Philip Oakley <philipoakley@iee.email>,
Sibi Siddharthan <sibisiddharthan.github@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Danh Doan <congdanhqx@gmail.com>
Subject: Re: [PATCH 1/3] cmake: add knob to disable vcpkg
Date: Fri, 4 Jun 2021 14:34:08 -0400 [thread overview]
Message-ID: <CAOjrSZuO14F2ShmfYeTdf39YOhWDJWFm2PQtXR5abJh5FsigYw@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cRBQYbhPbvGvEcmqUFmXM4yysRnWam=Sx_Lr8uWbEZVMg@mail.gmail.com>
On Fri, Jun 4, 2021 at 2:03 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Fri, Jun 4, 2021 at 1:44 PM Matthew Rogers via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > When building on windows users have the option to use vcpkg to provide
> > the dependencies needed to compile. Previously, this was used only when
> > using the Visual Studio generator which was not ideal because:
> >
> > - Not all users who want to use vcpkg use the Visual Studio
> > generators.
> >
> > - Some versions of Visual Studio 2019 moved away from using the
> > VS 2019 by default, making it impossible for Visual Studio to
> > configure the project in the likely event that it couldn't find the
> > dependencies.
>
> Is there something missing between "using the" and "VS 2019"? I'm
> having a hard time trying to understand what this bullet point is
> saying due to this apparent gap.
>
Yeah, this should really read
- Some versions of Visual Studio 2019 moved away from using the
VS 2019 _Generator_ by default, making it impossible for Visual Studio to
configure the project in the likely event that it couldn't find the
dependencies.
> > - Inexperienced users of CMake are very likely to get tripped up by
> > the errors caused by a lack of vcpkg, making the above bullet point
> > both annoying and hard to debug.
> >
> > As such, lets make using vcpkg the default on windows. Users who want
> > to avoid using vcpkg can disable it by passing -DNO_VCPKG=TRUE.
>
> s/lets/let's/
>
> > Signed-off-by: Matthew Rogers <mattr94@gmail.com>
--
Matthew Rogers
next prev parent reply other threads:[~2021-06-04 18:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 17:43 [PATCH 0/3] Make CMake work out of the box Matthew Rogers via GitGitGadget
2021-06-04 17:43 ` [PATCH 1/3] cmake: add knob to disable vcpkg Matthew Rogers via GitGitGadget
2021-06-04 18:03 ` Eric Sunshine
2021-06-04 18:34 ` Matt Rogers [this message]
2021-06-04 20:55 ` Sibi Siddharthan
2021-06-05 22:30 ` Matt Rogers
2021-06-06 4:33 ` Sibi Siddharthan
2021-06-04 17:43 ` [PATCH 2/3] cmake: create compile_commands.json by default Matthew Rogers via GitGitGadget
2021-06-04 18:05 ` Eric Sunshine
2021-06-04 21:09 ` Sibi Siddharthan
2021-06-05 22:36 ` Matt Rogers
2021-06-06 4:39 ` Sibi Siddharthan
2021-06-04 17:43 ` [PATCH 3/3] cmake: add warning for ignored MSGFMT_EXE Matthew Rogers via GitGitGadget
2021-06-04 18:10 ` Eric Sunshine
2021-06-05 3:40 ` [PATCH 0/3] Make CMake work out of the box Bagas Sanjaya
2021-06-05 23:22 ` Matt Rogers
2021-06-10 9:43 ` Johannes Schindelin
2021-06-18 13:05 ` Philip Oakley
2021-06-18 13:42 ` Johannes Schindelin
2021-06-18 14:03 ` Philip Oakley
2021-06-22 22:32 ` Johannes Schindelin
2021-06-06 12:02 ` [PATCH v2 " Matthew Rogers via GitGitGadget
2021-06-06 12:02 ` [PATCH v2 1/3] cmake: add knob to disable vcpkg Matthew Rogers via GitGitGadget
2021-06-06 12:02 ` [PATCH v2 2/3] cmake: create compile_commands.json by default Matthew Rogers via GitGitGadget
2021-06-06 12:02 ` [PATCH v2 3/3] cmake: add warning for ignored MSGFMT_EXE Matthew Rogers via GitGitGadget
2021-06-07 0:54 ` [PATCH v2 0/3] Make CMake work out of the box Junio C Hamano
2021-06-10 9:45 ` Johannes Schindelin
2021-06-18 13:11 ` Philip Oakley
2021-06-18 13:09 ` Philip Oakley
2021-06-10 9:47 ` Johannes Schindelin
2021-06-11 6:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOjrSZuO14F2ShmfYeTdf39YOhWDJWFm2PQtXR5abJh5FsigYw@mail.gmail.com \
--to=mattr94@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=philipoakley@iee.email \
--cc=sibisiddharthan.github@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).