From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 2E42F1F463 for ; Fri, 20 Dec 2019 22:58:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726539AbfLTW6f (ORCPT ); Fri, 20 Dec 2019 17:58:35 -0500 Received: from mail-ua1-f65.google.com ([209.85.222.65]:41842 "EHLO mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726030AbfLTW6f (ORCPT ); Fri, 20 Dec 2019 17:58:35 -0500 Received: by mail-ua1-f65.google.com with SMTP id f7so3827146uaa.8 for ; Fri, 20 Dec 2019 14:58:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AyQz2rd8PLcd4PZv4OG6N9vmSFDMm48GmQOpA822kjI=; b=B6lKeoXtPxrLo+wTQsrgPAh/bfn55D7Vh1lXG26xoIYAQ0kw39A0dLAbrUocBZOYcQ pNFRXi5/LDjgCmvyOkrapNgxAYEI2ljTaVvKKeGBUePb6h7Fcno0X8tX8u4OgBkappQc 6oRq55uE8S5T8KDXTCejh8Id8wzqvKp+1LIDhJ94kbUvizIcNmQkaQsuFQjWEcEe2ney 3gHClOlQUb4kSkNwFooJLxEjEfzCuApHRdvqddrzRmf9z7oaN6bbrKgiJBZXuNCMiv4E KUNw2bzKnopHzsD2mBZ5Xln1tM5AfVPbfADsZo63eEhRPebM+dxAYM+4rJLxQDH3nsXX QABQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AyQz2rd8PLcd4PZv4OG6N9vmSFDMm48GmQOpA822kjI=; b=FRlr3tYS3GgqoM/hnyRS7/YyELiLzePoPAhQ0i8T6ZQpIsSVQgqE/CRv6uWcsbLv/r +ttzMVclTWkLgKM4AGBgCUIKoi9D7zpvH85CCr6n6cawjHaZ2I5SioqD4Sqy8TYQCXq8 y7wIwKJlrguGV9FTnIAWjXmHyeXMALcVRV8WAxZRLvGXKi+3Yr+Z9kr9czucFxZzJ+1d 8p4jp66wsB9VWWVPUhAFm8DTs4r1BbxZqoBBz/w8ILc5KvRKCTYj0ZWs81BUVcmgLFzx yMH1dJazvXG+idhQ/qeIhinWMN0df6jKoC8JC1sJdHpqb2+HMDiF24orSO5dtzoRvmgF PjoA== X-Gm-Message-State: APjAAAWnK9jFvdHJEV3qU7eHkwNvW6rX7BfVY1b4euz2cikXye8KyFPJ GsRQJrEy3rH7E4JPihz6JRRZoORTV5oBqlar3Ic= X-Google-Smtp-Source: APXvYqxC7R23PFrpS6rdflFSIpowmxX/ZeXvvJAjkwdwpAMRDfydjAjqIZ//OuoAkrhqZlUgcfPo5O0/ltDjuBIdtoM= X-Received: by 2002:a9f:2e03:: with SMTP id t3mr10713146uaj.119.1576882714365; Fri, 20 Dec 2019 14:58:34 -0800 (PST) MIME-Version: 1.0 References: <9a91caa0-72c3-3a38-3eb7-55a43537762e@iee.email> <03b001d5b601$09b950e0$1d2bf2a0$@gmail.com> In-Reply-To: From: Matt Rogers Date: Fri, 20 Dec 2019 17:58:22 -0500 Message-ID: Subject: Re: [PATCH 1/1] config: allow user to know scope of config options To: Junio C Hamano Cc: Philip Oakley , Matthew Rogers via GitGitGadget , git@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Philip, >The commit message doesn't fully highlight that the config list will >often be all the users config values, so each value will be >disambiguated/identified as to it's origin. I don't really understand what you mean by "it's origin" here. When you say origin, do you mean in the "--show-origin" sense of "file/blob/etc." or something else? Because scope is kind of an orthogonal concept to origin in that sense as you can have files with different origins but the same scope. Thanks, Matt On Thu, Dec 19, 2019 at 12:56 PM Junio C Hamano wrote: > > writes: > > >>These are correct changes, but is unrelated noise in the context of > >>the theme of the patch, no? > > > > I think that's the case, would the recommended course of action be to > > move these changes into its own commit? > > > > Yup, and it generally is a good idea to make such a clean-up patch > either early in the series, or as a standalone patch (with a note > under three-dash lines that another topic is coming on top of the > cleanup), because it would be much less likely to introduce new bugs > and can be merged quicly to 'next' and then to 'master' to serve as > a base to build your other changes on top. > -- Matthew Rogers