git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Halil SEN <halilsen@gmail.com>
To: Shulhan <ms@kilabit.info>
Cc: git@vger.kernel.org, paulus@ozlabs.org
Subject: Re: [PATCH] gitk: fix error when resizing gitk
Date: Wed, 23 Feb 2022 16:03:55 +0100	[thread overview]
Message-ID: <CAOeUTuuyftWB=PaA9HPDnyxsb40R3Z6GD65TB92jEW+38goqRg@mail.gmail.com> (raw)
In-Reply-To: <20211125125720.231039-1-ms@kilabit.info>

Hello Shulhan,

I just stumbled upon your patch while looking for the patch
that I sent at the beginning of this week for the exact same
issue.  It turns out you sent your patch two months ago.  I
should have checked before debugging :face_palm:

If you would like to check it out, here is my patch in [1].

I see that you have fixed resizeclistpanes but exact same issue
is present on resizecdetpanes as well.

I am not sure if the conditional logic is necessary because we
are sure that `sash#` includes x, y positions in ttk mode but it
includes only the x position if not ttk. Also setting the y coord
to 0 might have unintended consequences.


[1] https://lore.kernel.org/git/0b5b8fb591e434a2a24b1f58d1ce3fc7da48a28e.1645386457.git.gitgitgadget@gmail.com/

Signed-off-by: Halil Sen <halil.sen@gmail.com>

  reply	other threads:[~2022-02-23 15:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 12:57 [PATCH] gitk: fix error when resizing gitk Shulhan
2022-02-23 15:03 ` Halil SEN [this message]
2022-02-23 17:16   ` Shulhan
  -- strict thread matches above, loose matches on Subject: below --
2021-11-21  7:33 Shulhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOeUTuuyftWB=PaA9HPDnyxsb40R3Z6GD65TB92jEW+38goqRg@mail.gmail.com' \
    --to=halilsen@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ms@kilabit.info \
    --cc=paulus@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).