From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
To: Git List <git@vger.kernel.org>
Subject: Re: [PATCH v1] builtin/checkout.c: replace bit-shift values for macros in call to check_stages
Date: Sat, 6 Jun 2020 23:54:06 -0600 [thread overview]
Message-ID: <CAOc6etZGw5SUj_ijWZtDjN44i7WLMKrUKALCpmfPAPxZK1c-tw@mail.gmail.com> (raw)
In-Reply-To: <20200607054849.1014185-1-eantoranz@gmail.com>
On Sat, Jun 6, 2020 at 11:49 PM Edmundo Carmona Antoranz
<eantoranz@gmail.com> wrote:
>
> Currently a call to check_stages is using bit-shift values to define what will be used
> as the first argument. If the reader doesn't know what the values are from heart, they
> have to go dig in cache.h what each value is.
>
> This patch is replacing those values for the macros from cache.h so that it's
> clear at first sight what they are (CE_ENTRY_REMOVED, CE_ENTRY_ADDED)
The macros are defined since at least v2.1.0 and I am able to apply
the patch on top of it. Should
I send the patch from that version? I am sending on top of v2.22.4
cause it's the oldest version I
was able to compile successfully.
next prev parent reply other threads:[~2020-06-07 5:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 5:48 [PATCH v1] builtin/checkout.c: replace bit-shift values for macros in call to check_stages Edmundo Carmona Antoranz
2020-06-07 5:54 ` Edmundo Carmona Antoranz [this message]
2020-06-09 20:22 ` Junio C Hamano
2020-06-10 5:15 ` Edmundo Carmona Antoranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOc6etZGw5SUj_ijWZtDjN44i7WLMKrUKALCpmfPAPxZK1c-tw@mail.gmail.com \
--to=eantoranz@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).