From: Karthik Nayak <karthik.188@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Git <git@vger.kernel.org>, Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH v7 10/11] ref-filter: implement '--contains' option
Date: Thu, 2 Jul 2015 22:54:16 +0530 [thread overview]
Message-ID: <CAOLa=ZTDn3cQf4ax4kMA+g7zDJrsHicyXZuEc72am8An=6EuGg@mail.gmail.com> (raw)
In-Reply-To: <vpqr3oq7abs.fsf@anie.imag.fr>
On Thu, Jul 2, 2015 at 10:42 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> 'tag -l' and 'branch -l' have two different ways of finding
>> out if a certain ref contains a commit. Implement both these
>> methods in ref-filter and give the caller of ref-filter API
>> the option to pick which implementation to be used.
>
> You are reusing some code, but unlike the other patches you are not
> marking the old code as duplicated. The "duplicate code" comment both
> acts as a reminder for later, and as an indication for reviewers of
> where the code comes from.
>
Ah! I didn't really mark it cause unlike the others this isn't a
single function but rather
a whole block of code, but what you're saying makes sense.
Thanks.
next prev parent reply other threads:[~2015-07-02 17:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 15:20 [PATCH v7 00/11] add options to for-each-ref Karthik Nayak
2015-07-02 15:21 ` [PATCH v7 01/11] t6302: for-each-ref tests for ref-filter APIs Karthik Nayak
2015-07-02 15:21 ` [PATCH v7 02/11] tag: libify parse_opt_points_at() Karthik Nayak
2015-07-02 15:21 ` [PATCH v7 03/11] ref-filter: implement '--points-at' option Karthik Nayak
2015-07-02 15:21 ` [PATCH v7 04/11] for-each-ref: add " Karthik Nayak
2015-07-02 17:05 ` Matthieu Moy
2015-07-05 16:01 ` Karthik Nayak
2015-07-02 15:21 ` [PATCH v7 05/11] ref-filter: add parse_opt_merge_filter() Karthik Nayak
2015-07-02 17:06 ` Matthieu Moy
2015-07-02 17:21 ` Karthik Nayak
2015-07-02 15:21 ` [PATCH v7 06/11] ref-filter: implement '--merged' and '--no-merged' options Karthik Nayak
2015-07-02 15:21 ` [PATCH v7 07/11] for-each-ref: add " Karthik Nayak
2015-07-02 15:21 ` [PATCH v7 08/11] parse-option: rename parse_opt_with_commit() Karthik Nayak
2015-07-02 15:21 ` [PATCH v7 09/11] parse-options.h: add macros for '--contains' option Karthik Nayak
2015-07-02 17:08 ` Matthieu Moy
2015-07-02 17:22 ` Karthik Nayak
2015-07-02 15:21 ` [PATCH v7 10/11] ref-filter: implement " Karthik Nayak
2015-07-02 17:12 ` Matthieu Moy
2015-07-02 17:24 ` Karthik Nayak [this message]
2015-07-02 15:21 ` [PATCH v7 11/11] for-each-ref: add " Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLa=ZTDn3cQf4ax4kMA+g7zDJrsHicyXZuEc72am8An=6EuGg@mail.gmail.com' \
--to=karthik.188@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).