git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Karthik Nayak <karthik.188@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Toon Claes <toon@iotcl.com>
Subject: Re: [PATCH v5 2/2] attr: add flag `--source` to work with tree-ish
Date: Wed, 4 Jan 2023 11:25:21 +0100	[thread overview]
Message-ID: <CAOLa=ZStKKgyaHGjGVpQ5jsSpkdqXuH2RhvWOgrU2qKxGbQFGA@mail.gmail.com> (raw)
In-Reply-To: <xmqq1qocwlr9.fsf@gitster.g>

On Tue, Jan 3, 2023 at 12:38 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> Likewise.
>
> Perhaps squash something like this in in the next iteration?
>
>  attr.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git i/attr.h w/attr.h
> index 84a3279215..fca6c30430 100644
> --- i/attr.h
> +++ w/attr.h
> @@ -108,6 +108,7 @@
>   */
>
>  struct index_state;
> +struct object_id;
>
>  /**
>   * An attribute is an opaque object that is identified by its name. Pass the

Thanks Junio, I'll squash this in, waiting for more reviews before
rolling out a new version.

-- 
- Karthik

  reply	other threads:[~2023-01-04 10:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <https://lore.kernel.org/git/cover.1671630304.git.karthik.188@gmail.com/>
2023-01-02 11:04 ` [PATCH v5 0/2] check-attr: add support to work with tree-ish Karthik Nayak
2023-01-02 11:04   ` [PATCH v5 1/2] t0003: move setup for `--all` into new block Karthik Nayak
2023-01-02 11:04   ` [PATCH v5 2/2] attr: add flag `--source` to work with tree-ish Karthik Nayak
2023-01-02 23:38     ` Junio C Hamano
2023-01-04 10:25       ` Karthik Nayak [this message]
2023-01-11 11:30     ` Phillip Wood
2023-01-12 10:53       ` Karthik Nayak
2023-01-12 13:20     ` Ævar Arnfjörð Bjarmason
2023-01-14  8:26       ` Karthik Nayak
2023-01-09  9:10   ` [PATCH v5 0/2] check-attr: add support " Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOLa=ZStKKgyaHGjGVpQ5jsSpkdqXuH2RhvWOgrU2qKxGbQFGA@mail.gmail.com' \
    --to=karthik.188@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).