From: Karthik Nayak <karthik.188@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: "Torsten Bögershausen" <tboegi@web.de>, Git <git@vger.kernel.org>,
"Christian Couder" <christian.couder@gmail.com>
Subject: Re: [PATCH v8 01/11] t6302: for-each-ref tests for ref-filter APIs
Date: Thu, 9 Jul 2015 11:22:52 +0530 [thread overview]
Message-ID: <CAOLa=ZS3Sb=OjGFZWykLKctdvoZNy0WCoOfQct--+5W4ck6FYQ@mail.gmail.com> (raw)
In-Reply-To: <vpq615ud53i.fsf@anie.imag.fr>
On Wed, Jul 8, 2015 at 9:16 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> On Wed, Jul 8, 2015 at 2:37 PM, Matthieu Moy
>> <Matthieu.Moy@grenoble-inp.fr> wrote:
>>> Torsten Bögershausen <tboegi@web.de> writes:
>>>
>>>> Could we have a tweak for people without gpg?
>>>
>>> I guess we need stg like
>>>
>>> if ! test_have_prereq GPG; then
>>> skip_all='skipping for-each-ref tests, gpg not available'
>>> test_done
>>> fi
>>>
>>> since we need GPG in the setup test and almost all other tests will rely
>>> on it.
>>>
>>
>> Does this need to be there? I see a lot of test files which need GPG, and since
>> this test file contains tests which rely on it, without it, it would
>> be kinda useless
>> anyways?
>
> In many cases, the tests look like
>
> . lib-gpg.sh
>
> test_expect_success 'test that does not use GPG' '
> ...
> '
>
> test_expect_success GPG 'test that does use GPG' '
> ...
> '
>
> so you can't decide in lib-gpg.sh that you'll skip all tests, because
> you would skip some tests that could be ran without gpg.
>
Ah! Thanks. Will reply here with your fix included :)
--
Regards,
Karthik Nayak
next prev parent reply other threads:[~2015-07-09 5:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 16:05 [PATCH v8 00/11] add options to for-each-ref Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 01/11] t6302: for-each-ref tests for ref-filter APIs Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 02/11] tag: libify parse_opt_points_at() Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 03/11] ref-filter: implement '--points-at' option Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 04/11] for-each-ref: add " Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 05/11] ref-filter: add parse_opt_merge_filter() Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 06/11] ref-filter: implement '--merged' and '--no-merged' options Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 07/11] for-each-ref: add " Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 08/11] parse-option: rename parse_opt_with_commit() Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 09/11] parse-options.h: add macros for '--contains' option Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 10/11] ref-filter: implement " Karthik Nayak
2015-07-07 16:06 ` [PATCH v8 11/11] for-each-ref: add " Karthik Nayak
2015-07-08 8:09 ` [PATCH v8 01/11] t6302: for-each-ref tests for ref-filter APIs Torsten Bögershausen
2015-07-08 9:07 ` Matthieu Moy
2015-07-08 13:59 ` Karthik Nayak
2015-07-08 15:46 ` Matthieu Moy
2015-07-09 5:52 ` Karthik Nayak [this message]
2015-07-09 6:03 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLa=ZS3Sb=OjGFZWykLKctdvoZNy0WCoOfQct--+5W4ck6FYQ@mail.gmail.com' \
--to=karthik.188@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).