From: Karthik Nayak <karthik.188@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Git <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v7 0/11] port tag.c to use ref-filter APIs
Date: Mon, 3 Aug 2015 12:52:31 +0530 [thread overview]
Message-ID: <CAOLa=ZS1GkN3KHRk2NauC64gye9HOM_LLR0uvDHMDh--UWmrPg@mail.gmail.com> (raw)
In-Reply-To: <vpqoaipbnpa.fsf@anie.imag.fr>
On Sun, Aug 2, 2015 at 11:02 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> +test_expect_success 'no padding when `padright` length is smaller than atom length' '
>> + cat >expect <<-\EOF &&
>> + refs/heads/master|
>> + refs/heads/side|
>> + refs/odd/spot|
>> + refs/tags/double-tag|
>> + refs/tags/four|
>> + refs/tags/one|
>> + refs/tags/signed-tag|
>> + refs/tags/three|
>> + refs/tags/two|
>> + EOF
>> + git for-each-ref --format="%(padright:5)%(refname)|" >actual &&
>> test_cmp expect actual
>> '
>
> Nit: I think the test would be better with padright:15 for example, to
> show that some lines are aligned and some go beyond the 15 columns.
>
I've added something like this :)
--
Regards,
Karthik Nayak
prev parent reply other threads:[~2015-08-03 7:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 15:34 [PATCH v7 0/11] port tag.c to use ref-filter APIs Karthik Nayak
2015-07-30 15:48 ` [PATCH v7 01/11] ref-filter: introduce 'ref_formatting_state' Karthik Nayak
2015-07-30 15:48 ` [PATCH v7 02/11] ref-filter: make `color` use `ref_formatting_state` Karthik Nayak
2015-07-30 15:48 ` [PATCH v7 03/11] ref-filter: add option to pad atoms to the right Karthik Nayak
2015-07-30 17:56 ` Eric Sunshine
2015-08-01 6:03 ` Karthik Nayak
2015-07-30 15:48 ` [PATCH v7 04/11] ref-filter: add option to filter only tags Karthik Nayak
2015-07-30 15:48 ` [PATCH v7 05/11] ref-filter: support printing N lines from tag annotation Karthik Nayak
2015-07-30 15:48 ` [PATCH v7 06/11] ref-filter: add support to sort by version Karthik Nayak
2015-07-30 15:48 ` [PATCH v7 07/11] ref-filter: add option to match literal pattern Karthik Nayak
2015-07-30 15:48 ` [PATCH v7 08/11] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-07-30 15:48 ` [PATCH v7 09/11] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-07-30 15:48 ` [PATCH v7 10/11] tag.c: implement '--format' option Karthik Nayak
2015-07-30 15:48 ` [PATCH v7 11/11] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
2015-07-30 15:49 ` [PATCH v7 0/11] port tag.c to use ref-filter APIs Karthik Nayak
2015-08-02 17:32 ` Matthieu Moy
2015-08-03 7:22 ` Karthik Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLa=ZS1GkN3KHRk2NauC64gye9HOM_LLR0uvDHMDh--UWmrPg@mail.gmail.com' \
--to=karthik.188@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).