git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Karthik Nayak <karthik.188@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2025, #02)
Date: Fri, 12 Dec 2025 15:29:32 -0600	[thread overview]
Message-ID: <CAOLa=ZRfhKMnnb-4n19Vy0kzBc3QV0df05WNur1_OFa40YssAA@mail.gmail.com> (raw)
In-Reply-To: <xmqqwm2uh7gs.fsf@gitster.g>

[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]

Junio C Hamano <gitster@pobox.com> writes:

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>>>>>  Expecting a (hopefully small and final) reroll.
>>>>>  cf. <CAOLa=ZQ-O7V9qHbgeuQ78R1bHGDmGEM6fP5Kr9aC0AfvSF8MZA@mail.gmail.com>
>>>>>  source: <20251121-fix-tags-not-fetching-v8-0-23b53a8a8334@gmail.com>
>>>>
>>>> The only change needed from the last review was a typo. I think we should be
>>>> good as is.
>>>
>>> Meaning that we prefer to leave the typo in, or just we won't die
>>> with a known typo?
>>
>> The typo was in a comment in the tests, so I thought it wasn't worth
>> re-rolling, but happy to do so.
>
> I went back to the discussion to find that single typo and tweaked
> it myself in my tree, so no need to resend.
>
> Thanks.
>
>
> diff --git c/t/t5510-fetch.sh w/t/t5510-fetch.sh
> index a1ca4e1ac7..ce1c23684e 100755
> --- c/t/t5510-fetch.sh
> +++ w/t/t5510-fetch.sh
> @@ -1628,7 +1628,7 @@ test_expect_success "backfill tags when providing a refspec" '
>  	    test_commit fetch-me
>  	) &&
>
> -	# The "history" tag is backfilled eventhough we requested
> +	# The "history" tag is backfilled even though we requested
>  	# to only fetch HEAD
>  	git -C target fetch origin HEAD:branch &&
>  	git -C target tag -l >actual &&

Thanks for handling it. This looks good to me :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 690 bytes --]

  reply	other threads:[~2025-12-12 21:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09 21:08 What's cooking in git.git (Dec 2025, #02) Junio C Hamano
2025-12-09 22:46 ` Karthik Nayak
2025-12-09 23:10   ` Junio C Hamano
2025-12-10 10:04     ` Karthik Nayak
2025-12-10 12:00       ` Junio C Hamano
2025-12-12 21:29         ` Karthik Nayak [this message]
2025-12-10  7:55 ` Kristoffer Haugsbakk
2025-12-10  9:20   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOLa=ZRfhKMnnb-4n19Vy0kzBc3QV0df05WNur1_OFa40YssAA@mail.gmail.com' \
    --to=karthik.188@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://public-inbox.org/mirrors/git.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).