Re: [PATCH 0/9] reftable: optimize table and block iterators

[Karthik Nayak <karthik.188@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]

Patrick Steinhardt <ps@pks.im> writes:

> Hi,
>
>  * The code to iterate over reftable blocks has seen some optimization
>    to reduce memory allocation and deallocation.
>
> Preceding patch series have optimized memory allocation patterns when
> iterating through ref or log records. This has led to a constant number
> of allocations when decoding and yielding those records to our callers.
> One thing that is still missing though is an optimization for the table
> and block iterators which are responsible for iterating through the
> separate blocks in the table. So while the number of allocations does
> not scale with the number of refs (directly) anymore, it still scales
> with the number of blocks.
>
> This is getting tackled by this patch series now which refactors the
> table and block iterators such that the former can reuse the latter
> without reallocations. With this change iterating through records is now
> using a truly constant number of allocations.

This patch series already looks good to me, I have nothing to add here.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 690 bytes --]