From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 7FD1A1F9FC for ; Thu, 18 Mar 2021 15:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232049AbhCRP2S (ORCPT ); Thu, 18 Mar 2021 11:28:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231874AbhCRP1w (ORCPT ); Thu, 18 Mar 2021 11:27:52 -0400 Received: from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA09AC06174A for ; Thu, 18 Mar 2021 08:27:51 -0700 (PDT) Received: by mail-oo1-xc34.google.com with SMTP id i25-20020a4aa1190000b02901bbd9429832so1536670ool.0 for ; Thu, 18 Mar 2021 08:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AYDFVDqJrfvHCeMDNBI2L+DywGAsH4khVgCdApaosHE=; b=smMz5DNpTxf/fPmDc5g1mNXRK7o6g7WHHkI5WcjOAoVIHmMAwV9DIDu3ysd3BznP7W HNXSD6TIk8GIEOHQTo2AHHxN9xdurTiBhFXlxyxO4RL/MzllgOBClgGziJCqneK30Tta QhFSjNKdGGqnPa8U2Vt9IK7f1tibSEPEv+tpBZHQmi/SLhrDZp4d0ioTGV2BNGEQ9OhA 7824mOwKwckRQRZD4kExE4qyO4pk8t6dvoYpFmxk05h+0NRoKNe+l9rWRalgQU3qfa8f jj/+XDxnABfdil72zR4KXZFn2+321nEb9FBwzpfBYZZXATlOBAbq8EFSTPjk+ly10e2w M2uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AYDFVDqJrfvHCeMDNBI2L+DywGAsH4khVgCdApaosHE=; b=ddxwJmsUsr/xIjBbGZf9sPOmNuPqoLohFWN15ai8gfwT4SFFlI+c6G9uSvhtGvUGn6 nePeMVYDjW7puOF+TCDXEyDEndEHmiDP1FAp3l6I1q6m7JOoUFDgCj7ULyZszCcdl5Mq C/Pw/fVInyzRrckPlMj8qH7T0A3Br+8YQRrboARJdLTRIWzkcK7V/TA1/JO5ZpOFIrLO krl49xezzIR8tb6oTz4NLbaC0rIMNQAvgahzAQXRyFK40MK55MbeqqO9pIgchD1bhwFP SThxMh15pCSAtqup6MKZ8buA8bCniR264pbV7JzhO0hw4gTAtbu9CE3VbX1/c8Wb4An+ /FHw== X-Gm-Message-State: AOAM531FfozmCX6u917ZbGrluYl+U7wzifGJJf7142YSYZtpcYFyd4jx cfAI7/xknZEKWWSqO2H83Pxwpam9Bh4uGvao1Uc= X-Google-Smtp-Source: ABdhPJwit0/UW3HDbLycGuH/ZON7Qj9UEXu+mdk3AbfJpTSkYZ3uBMrQrN/sMTxxaI6XwaQkn21s6zuWWIPV0L8EAvo= X-Received: by 2002:a4a:bd97:: with SMTP id k23mr7945499oop.13.1616081271245; Thu, 18 Mar 2021 08:27:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: ZheNing Hu Date: Thu, 18 Mar 2021 23:27:40 +0800 Message-ID: Subject: Re: [PATCH v10 0/3] [GSOC] commit: add --trailer option To: Christian Couder Cc: ZheNing Hu via GitGitGadget , git , "Bradley M. Kuhn" , Junio C Hamano , Brandon Casey , Shourya Shukla , Rafael Silva Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Christian Couder =E4=BA=8E2021=E5=B9=B43=E6=9C= =8818=E6=97=A5=E5=91=A8=E5=9B=9B =E4=B8=8B=E5=8D=889:48=E5=86=99=E9=81=93= =EF=BC=9A > > On Thu, Mar 18, 2021 at 12:15 PM ZheNing Hu via GitGitGadget > wrote: > > > > Now maintainers or developers can also use commit > > --trailer=3D"Signed-off-by:commiter" from the command line to pr= ovide > > trailers to commit messages. This solution may be more generalized than= v1. > > > > ZheNing Hu (3): > > [GSOC] commit: add --trailer option > > interpret-trailers: add own-identity option > > commit: add own-identity option > > I see that you discussed an own-identity option in this thread > recently, but this is version 10 of a patch series, so I don't think > it's a good idea to introduce new features at this point. I think it's > better to not tie the work that has already been done on polishing the > first patch to new patches implementing an additional feature. The > additional feature can be discussed and worked on in its own patch > series building on top of this one. > OK, I understand that now. I will divide this patch series into two parts. > Also it feels strange that only the first patch has "[GSOC]". I forgot to add [GSOC]... Thanks.