Re: [PATCH v6] [GSOC] trailer: add new trailer.<token>.cmd config option

[ZheNing Hu <adlternative@gmail.com>]

Hi, Junio and Christian,

Christian Couder <christian.couder@gmail.com> 于2021年4月6日周二 上午11:52写道：
>
> On Tue, Apr 6, 2021 at 5:47 AM Christian Couder
> <christian.couder@gmail.com> wrote:
> >
> > On Mon, Apr 5, 2021 at 1:26 AM Junio C Hamano <gitster@pobox.com> wrote:
> > >
> > > Christian Couder <christian.couder@gmail.com> writes:
>
> > > > I would say it would behave as if:
> > > >
> > > > $ git interpret-trailers --trailer Foo= input-file
> > >
> > > Hmmm.  That means that the descrition in the original is quite
> > > misleading, no?
> >
> > Yeah, I agree it is misleading and difficult to understand.
> >
> > > If it said
> > >
> > >         ... as if "--trailer" "<token>=<value>" arguments were given
> > >         to "git interpret-trailers" command near the beginning of
> > >         its command line
> > >
> > > then that may be closer description of the command line you are
> > > forming, but as its written (with or without my attempt to clarify
> > > above), it was impossible to infer that you are behaving as if
> > > another --trailer option (with <token>=<value> as its value) was
> > > given.
> >
> > I agree.
>
> By the way it might be better to first have a patch that clarifies the
> existing documentation of ".command", before the patch that adds
> ".cmd". This way the first patch that only clarifies the documentation
> could be backported to maintenance branches of old releases.

This first patch should explain errors of ".command", and then explain that
we will no longer use it, right?

I find in the status update description:
"Seems to break new tests for .command variant in zh/commit-trailer"
I have tryed to merge my local branch 1e9a657(trailer-cmd) and
2daae3d(upstream/zh/commit-trailer)

I can't find any tests errors after merging, is there something unexpected
happened?

--
ZheNing Hu