From: ZheNing Hu <adlternative@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v5] [GSOC] ref-filter: fix read invalid union member bug
Date: Wed, 12 May 2021 18:37:05 +0800 [thread overview]
Message-ID: <CAOLTT8SroeHvZRiRMoeBAPo-nuAvYOzxRx=fq=DxnpUfy4zVsw@mail.gmail.com> (raw)
In-Reply-To: <xmqq35usivi4.fsf@gitster.g>
> > + test_when_finished "cd .. && rm -rf ./test" &&
>
> Not a very good practice to chdir around, even if you have
> when-finished clean-up. Not worth risking "rm -rf" at random
> places when for example somebody breaks when-finished.
>
OK.
> Instead...
>
> > + mkdir test &&
>
> Place everything below ...
>
> > + cd test &&
> > + git init &&
> > + cat >expect <<-\EOF &&
> > + refs/heads/main
> > + EOF
> > + git add . &&
> > + git branch -M main &&
>
> This is in a freshly created repository without commit. Does
> "branch -M" work for such an unborn branch? Perhaps start this
> block like so:
>
I think "git branch -M" before "git commit" also will be fine.
Of course it's okay to put it after commit and before "test_cmp".
> git init test &&
> (
> cd test &&
> test_commit initial &&
> git branch -M main &&
> cat >expect <<-\EOF &&
> refs/heads/main
> refs/tags/initial
> EOF
> git remote add origin nowhere &&
> ...
>
> > + git commit -m "test" &&
> > + git remote add origin nowhere &&
> > + git config branch.main.remote origin &&
> > + git config branch.main.merge refs/heads/main &&
> > + git for-each-ref --format="%(color:#aa22ac)%(refname)" >actual &&
> > + test_cmp expect actual
>
> ... up to here inside a (subshell).
>
I get it now. By executing cd in the subshell, the "cd .." step can be
omitted.
> By the way, your use of "git branch -M" makes the test work whether
> the default initial branch name is still 'master' or already 'main'
> by forcing the branch used for testing to be 'main'. Clever ;-).
>
Hh, real knowledge comes from practice. Yesterday, I tried it on the old
version of git on some classmates’ computers, and there was an error,
so using "git branch -M main" can avoid this error.
> Will queue with all of the above suggestions squashed in; please see
> if the result is good when it is pushed out later today.
>
> Thanks.
>
Thanks!
--
ZheNing Hu
next prev parent reply other threads:[~2021-05-12 10:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 15:31 [PATCH] [GSOC] ref-filter: solve bugs caused by enumeration ZheNing Hu via GitGitGadget
2021-05-06 1:53 ` Junio C Hamano
2021-05-06 5:02 ` ZheNing Hu
2021-05-06 5:35 ` Junio C Hamano
2021-05-06 10:39 ` ZheNing Hu
2021-05-06 11:20 ` Junio C Hamano
2021-05-06 11:52 ` ZheNing Hu
2021-05-06 21:20 ` Junio C Hamano
2021-05-07 4:32 ` ZheNing Hu
2021-05-07 4:49 ` Junio C Hamano
2021-05-07 5:09 ` ZheNing Hu
2021-05-06 16:31 ` [PATCH v2] [GSOC] ref-filter: fix read invalid union member bug ZheNing Hu via GitGitGadget
2021-05-08 15:26 ` [PATCH v3] " ZheNing Hu via GitGitGadget
2021-05-10 7:21 ` Junio C Hamano
2021-05-10 12:35 ` ZheNing Hu
2021-05-10 7:27 ` Junio C Hamano
2021-05-10 12:51 ` ZheNing Hu
2021-05-10 15:01 ` [PATCH v4] " ZheNing Hu via GitGitGadget
2021-05-11 2:29 ` Junio C Hamano
2021-05-11 6:28 ` ZheNing Hu
2021-05-11 9:30 ` Junio C Hamano
2021-05-11 11:47 ` ZheNing Hu
2021-05-11 13:12 ` Junio C Hamano
2021-05-11 13:31 ` ZheNing Hu
2021-05-11 15:35 ` [PATCH v5] " ZheNing Hu via GitGitGadget
2021-05-12 1:36 ` Junio C Hamano
2021-05-12 10:37 ` ZheNing Hu [this message]
2021-05-12 12:12 ` [PATCH v6] " ZheNing Hu via GitGitGadget
2021-05-12 23:24 ` Junio C Hamano
2021-05-13 9:29 ` ZheNing Hu
2021-05-13 15:13 ` [PATCH v7] " ZheNing Hu via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLTT8SroeHvZRiRMoeBAPo-nuAvYOzxRx=fq=DxnpUfy4zVsw@mail.gmail.com' \
--to=adlternative@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).