From: ZheNing Hu <adlternative@gmail.com> To: Junio C Hamano <gitster@pobox.com> Cc: Christian Couder <christian.couder@gmail.com>, ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>, git <git@vger.kernel.org> Subject: Re: [PATCH v4] [GSOC]trailer: pass arg as positional parameter Date: Thu, 1 Apr 2021 11:56:30 +0800 [thread overview] Message-ID: <CAOLTT8SV_ixYWTV-83vY6B6HUTwW1hTWJqamstf=F6tzkJm3aQ@mail.gmail.com> (raw) In-Reply-To: <xmqq7dln89dd.fsf@gitster.g> Junio C Hamano <gitster@pobox.com> 于2021年4月1日周四 上午2:29写道: > > Junio C Hamano <gitster@pobox.com> writes: > > > ZheNing Hu <adlternative@gmail.com> writes: > > > >> The configuration is like this: > >> trailer.bug.key=BUG: > >> trailer.bug.ifexists=add > >> trailer.bug.cmd=echo "123" > >> > >> And use: > >> > >> $ git interpret-trailers --trailer="bug:456" --trailer="bug:789"<<-EOF > >> EOF > >> > >> BUG: 123 > >> BUG: 123 456 > >> BUG: 123 789 > > > > I think that is quite expected. You said the command to run is > > 'echo 123', and that is not "pick a directory $D on $PATH where > > there is an executable '$D/echo 123' exists, and run that". It > > runs the given command with the shell, and in general that is > > what we want for end-user supplied commands specified in the > > configuration file [*1*]. > > ... > > *1* Imagine .editor set to 'emacs -nw' or 'vim -f'; we do not want > > Git to find a directory on $PATH that has an executable whose > > name is 'emacs -nw' and run that file (i.e. give 'emacs -nw' as > > the first argument to execlp()). Instead, you'd want to behave > > as if the user typed "emacs -nw", followed by any arguments we > > want to give to it (in .editor's case, the name of the file to > > be edited) properly quoted for the shell. > > > > And the way we do so is to form a moral equivalent of > > > > execlp("sh", "-c", "emacs -nw \"$@\"", ...); > > > > and put the arguments at the end where I wrote ... (we actually > > do so with execvp(), but illustrating with execlp() is easier to > > read and write---hence "a moral equivalent of"). > > So, learning from that .editor example, what you can do when you do > not want to take any parameter is to explicitly ignore them. > > Let's take the very basic form first. Imagine you wrote a little > script and wanted to see three "123", ignoring end-user input after > "--trailer=bug:". > > .cmd = my-script 123 > > would run 'my-script "$@"'. What should you write in my-script to > cause that happen? Here is an example solution: > > #!/bin/sh > echo 123 > > Notice that "$1" is completely ignored, even if the machinery that > drives .cmd makes three calls? > > sh -c 'my-script 123 "$@"' > sh -c 'my-script 123 "$@"' 456 > sh -c 'my-script 123 "$@"' 789 > > The way to do the same without an extra script on disk is for you to > use sh-c yourself. > > .cmd = sh -c 'echo 123' > This is indeed a viable solution, But the extra "sh -c" seems to put an unnecessary burden on the user. Sometimes I wonder, why not recommend using environment variables like $ARG? > And if you do want to use $1, you can do the same. E.g. if you want > to double them in the output, you'd probably do something like this: > > .cmd = sh -c 'echo "<$1 - $1>"' > > You'd need to quote the value appropriately for the config file, > though. In fact, In the following example, trailer <value> contains whitespaces , $ git interpret-trailers --trailer="bug:the information manager from hell" which can make it to work properly (But it's a little bit tedious): $ git config trailer.bug.cmd "sh -c \"echo \\\"\$1\"\\\"" $ git interpret-trailers --trailer="bug:the information manager from hell" Bug-from: Bug-from: the information manager from hell Is there an easier way? Or can make the user ignore the details of "sh -c"? Thanks. -- ZheNing Hu
next prev parent reply other threads:[~2021-04-01 3:57 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-23 14:53 [PATCH] [GSOC]trailer: change $ARG to environment variable ZheNing Hu via GitGitGadget 2021-03-24 15:42 ` [PATCH v2] [GSOC]trailer: pass arg as positional parameter ZheNing Hu via GitGitGadget 2021-03-24 20:18 ` Junio C Hamano 2021-03-25 1:43 ` ZheNing Hu 2021-03-25 11:53 ` [PATCH v3] " ZheNing Hu via GitGitGadget 2021-03-25 22:28 ` Junio C Hamano 2021-03-26 13:29 ` ZheNing Hu 2021-03-26 16:13 ` [PATCH v4] " ZheNing Hu via GitGitGadget 2021-03-27 18:04 ` Junio C Hamano 2021-03-27 19:53 ` Christian Couder 2021-03-28 10:46 ` ZheNing Hu 2021-03-29 9:04 ` Christian Couder 2021-03-29 13:43 ` ZheNing Hu 2021-03-30 8:45 ` Christian Couder 2021-03-30 11:22 ` ZheNing Hu 2021-03-30 15:07 ` ZheNing Hu 2021-03-30 17:14 ` Junio C Hamano 2021-03-31 5:14 ` ZheNing Hu 2021-03-31 18:19 ` Junio C Hamano 2021-03-31 18:29 ` Junio C Hamano 2021-04-01 3:56 ` ZheNing Hu [this message] 2021-04-01 19:49 ` Junio C Hamano 2021-04-02 2:08 ` ZheNing Hu 2021-04-01 3:39 ` ZheNing Hu 2021-03-31 10:05 ` [PATCH v5 0/2] " ZheNing Hu via GitGitGadget 2021-03-31 10:05 ` [PATCH v5 1/2] [GSOC] run-command: add shell_no_implicit_args option ZheNing Hu via GitGitGadget 2021-04-01 7:22 ` Christian Couder 2021-04-01 9:58 ` ZheNing Hu 2021-03-31 10:05 ` [PATCH v5 2/2] [GSOC]trailer: pass arg as positional parameter ZheNing Hu via GitGitGadget 2021-04-01 7:28 ` [PATCH v5 0/2] " Christian Couder 2021-04-01 10:02 ` ZheNing Hu 2021-04-02 13:26 ` [PATCH v6] [GSOC] trailer: add new trailer.<token>.cmd config option ZheNing Hu via GitGitGadget 2021-04-02 20:48 ` Junio C Hamano 2021-04-03 5:08 ` ZheNing Hu 2021-04-04 5:34 ` Junio C Hamano 2021-04-03 5:51 ` Christian Couder 2021-04-04 23:26 ` Junio C Hamano 2021-04-06 3:47 ` Christian Couder 2021-04-06 3:52 ` Christian Couder 2021-04-06 5:16 ` ZheNing Hu 2021-04-06 5:34 ` Junio C Hamano 2021-04-06 5:37 ` Junio C Hamano 2021-04-04 5:43 ` ZheNing Hu 2021-04-04 8:52 ` Christian Couder 2021-04-04 9:53 ` ZheNing Hu 2021-04-02 23:44 ` Junio C Hamano 2021-04-03 3:22 ` ZheNing Hu 2021-04-03 4:31 ` Junio C Hamano 2021-04-03 5:15 ` ZheNing Hu 2021-04-04 13:11 ` [PATCH v7] " ZheNing Hu via GitGitGadget 2021-04-06 16:23 ` Christian Couder 2021-04-07 4:51 ` ZheNing Hu 2021-04-09 13:37 ` [PATCH v8 0/2] [GSOC] trailer: add new .cmd " ZheNing Hu via GitGitGadget 2021-04-09 13:37 ` [PATCH v8 1/2] [GSOC] docs: correct descript of trailer.<token>.command ZheNing Hu via GitGitGadget 2021-04-09 19:02 ` Christian Couder 2021-04-10 13:40 ` ZheNing Hu 2021-04-09 13:37 ` [PATCH v8 2/2] [GSOC] trailer: add new .cmd config option ZheNing Hu via GitGitGadget 2021-04-09 20:18 ` Christian Couder 2021-04-10 14:09 ` ZheNing Hu 2021-04-09 19:59 ` [PATCH v8 0/2] " Christian Couder 2021-04-12 16:39 ` [PATCH v9 " ZheNing Hu via GitGitGadget 2021-04-12 16:39 ` [PATCH v9 1/2] [GSOC] docs: correct descript of trailer.<token>.command ZheNing Hu via GitGitGadget 2021-04-12 20:42 ` Junio C Hamano 2021-04-16 12:03 ` Christian Couder 2021-04-17 1:54 ` Junio C Hamano 2021-04-12 16:39 ` [PATCH v9 2/2] [GSOC] trailer: add new .cmd config option ZheNing Hu via GitGitGadget 2021-04-12 20:51 ` Junio C Hamano 2021-04-13 7:33 ` Christian Couder 2021-04-13 12:02 ` ZheNing Hu 2021-04-13 19:18 ` Junio C Hamano 2021-04-14 13:27 ` ZheNing Hu 2021-04-14 20:33 ` Junio C Hamano 2021-04-15 15:32 ` ZheNing Hu 2021-04-15 17:41 ` Junio C Hamano 2021-04-16 12:54 ` Christian Couder 2021-04-13 18:14 ` Junio C Hamano 2021-04-16 8:47 ` [PATCH v10 0/2] " ZheNing Hu via GitGitGadget 2021-04-16 8:47 ` [PATCH v10 1/2] [GSOC] docs: correct descript of trailer.<token>.command ZheNing Hu via GitGitGadget 2021-04-16 19:11 ` Junio C Hamano 2021-04-16 8:47 ` [PATCH v10 2/2] [GSOC] trailer: add new .cmd config option ZheNing Hu via GitGitGadget 2021-04-16 19:13 ` Junio C Hamano 2021-04-16 19:21 ` Junio C Hamano 2021-04-16 19:25 ` Junio C Hamano 2021-04-17 2:58 ` Junio C Hamano 2021-04-17 3:36 ` Junio C Hamano 2021-04-17 7:41 ` ZheNing Hu 2021-04-17 8:11 ` Junio C Hamano 2021-04-17 15:13 ` [PATCH v11 0/2] " ZheNing Hu via GitGitGadget 2021-04-17 15:13 ` [PATCH v11 1/2] [GSOC] docs: correct description of .command ZheNing Hu via GitGitGadget 2021-04-17 15:13 ` [PATCH v11 2/2] [GSOC] trailer: add new .cmd config option ZheNing Hu via GitGitGadget 2021-04-17 22:26 ` [PATCH v11 0/2] " Junio C Hamano 2021-04-18 7:47 ` ZheNing Hu 2021-04-21 0:09 ` Junio C Hamano 2021-04-21 5:47 ` ZheNing Hu 2021-04-21 23:40 ` Junio C Hamano 2021-04-22 9:20 ` ZheNing Hu 2021-04-27 6:49 ` Junio C Hamano 2021-04-27 12:24 ` ZheNing Hu 2021-05-03 15:41 ` [PATCH v12 " ZheNing Hu via GitGitGadget 2021-05-03 15:41 ` [PATCH v12 1/2] [GSOC] docs: correct descript of trailer.<token>.command ZheNing Hu via GitGitGadget 2021-05-03 15:41 ` [PATCH v12 2/2] [GSOC] trailer: add new .cmd config option ZheNing Hu via GitGitGadget
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOLTT8SV_ixYWTV-83vY6B6HUTwW1hTWJqamstf=F6tzkJm3aQ@mail.gmail.com' \ --to=adlternative@gmail.com \ --cc=christian.couder@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitgitgadget@gmail.com \ --cc=gitster@pobox.com \ --subject='Re: [PATCH v4] [GSOC]trailer: pass arg as positional parameter' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).