From: ZheNing Hu <adlternative@gmail.com> To: Junio C Hamano <gitster@pobox.com> Cc: Git List <git@vger.kernel.org> Subject: Re: What's cooking in git.git (Apr 2021, #06; Thu, 29) Date: Mon, 3 May 2021 21:35:45 +0800 [thread overview] Message-ID: <CAOLTT8SDb0sUfOYTBwvNQgdp9sOzOokxmPzXaCaB2ALbsYkHig@mail.gmail.com> (raw) In-Reply-To: <xmqq1raobncr.fsf@gitster.g> > > Here is a small typo error, I forget a small blank, which was pointed > > out by Josh > > Soref in https://github.com/gitgitgadget/git/pull/939 > > > > - '%ch':: committer date, human style(like the `--date=human` option of > > + '%ch':: committer date, human style (like the `--date=human` option of > > Please update it with an incremental patch as the topic has been > merged to 'next' a few days ago already. > OK, I will resubmit it. > > I have a little doubt here. Do I need to modify the "Commit-Count" > > example in the docs immediately? I thought this should be left to > > the next step? > > > > If necessary, I will make changes immediately. > > We've done the "after waiting" part already, so I should have > updated the topic summary for this one. > > I just re-read the second patch and the count example that leaves an > empty "commit-count:" does look strange. We probably want to update > it before the topic hits 'next'. While at it, you might want to add > the "Helped-by: " example we discussed. > > The phrase "global script" looks strange---just call it "script" > would be much easier to understand, as things that are in ~/bin do > not sound "global" to everybody (it is effective across > repositories, so is a bit wider than per-repository, but it is of > course not visible to other users). > > Thanks. I know what I should do now. Thanks. -- ZheNing Hu
prev parent reply other threads:[~2021-05-03 13:36 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-29 9:15 Junio C Hamano 2021-04-30 9:34 ` Ævar Arnfjörð Bjarmason 2021-05-02 6:47 ` Junio C Hamano 2021-05-06 4:29 ` Junio C Hamano 2021-05-06 15:36 ` Ævar Arnfjörð Bjarmason 2021-05-03 2:38 ` Junio C Hamano 2021-05-02 12:00 ` ZheNing Hu 2021-05-03 1:46 ` Junio C Hamano 2021-05-03 13:35 ` ZheNing Hu [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAOLTT8SDb0sUfOYTBwvNQgdp9sOzOokxmPzXaCaB2ALbsYkHig@mail.gmail.com \ --to=adlternative@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --subject='Re: What'\''s cooking in git.git (Apr 2021, #06; Thu, 29)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).