From: ZheNing Hu <adlternative@gmail.com>
To: Victoria Dye <vdye@github.com>
Cc: ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <derrickstolee@github.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] scalar: fix wrong shell hashbang
Date: Tue, 20 Sep 2022 20:43:40 +0800 [thread overview]
Message-ID: <CAOLTT8Rxh7dVJL6gGe1KPnTNOgPdQky06deOe0L5qczE0eh64g@mail.gmail.com> (raw)
In-Reply-To: <433bf552-db20-9989-92c5-ee625ce9337a@github.com>
Victoria Dye <vdye@github.com> 于2022年9月19日周一 04:08写道：
>
> ZheNing Hu via GitGitGadget wrote:
> > From: ZheNing Hu <adlternative@gmail.com>
> >
> > $SHELL_PATH_SQ haven't been set in scalar's Makefile,
> > bin-wrappers/scalar will begin with wrong hashbang "#!",
> > fix it by setting $SHELL_PATH and $SHELL_PATH_SQ in
> > scalar's Makefile.
> >
> > Signed-off-by: ZheNing Hu <adlternative@gmail.com>
> > ---
> > scalar: fix wrong shell hashbang
> >
> > The bin-wrappers/scalar seems like missing setting $SHELL_PATH_SQ which
> > lead to I can't execute bin-wrappers/scalar correctly, which output
> > error:
> >
> > zsh: exec format error: scalar
> >
> > (this bug will not turn out in bash)
> >
> > The bin-wrappers/scalar begin with wrong hashbang "#!", which cannot
> > figure out by zsh. So this patch want to fix this problem.
> >
> > v1: Setting $SHELL_PATH and $SHELL_PATH_SQ in scalar/Makefile.
> >
>
> Thanks for finding this! However, while your patch fixes the error you've
> identified (I was able to recreate both the original issue and apply your
> patch to fix it), I believe it has already been fixed in 'next' by
> 7b5c93c6c6 (scalar: include in standard Git build & installation,
> 2022-09-02) (archive: [1]).
>
> [1] https://lore.kernel.org/git/bc2092a7a7aae640b547bde8db0c0a26ce31278a.1662134210.git.gitgitgadget@gmail.com/
It seems that this problem has been solved, thanks!
--
ZheNing Hu
prev parent reply other threads:[~2022-09-20 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 13:11 [PATCH] scalar: fix wrong shell hashbang ZheNing Hu via GitGitGadget
2022-09-18 20:08 ` Victoria Dye
2022-09-19 18:44 ` Junio C Hamano
2022-09-20 12:43 ` ZheNing Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOLTT8Rxh7dVJL6gGe1KPnTNOgPdQky06deOe0L5qczE0eh64g@mail.gmail.com \
--to=adlternative@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).