From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-2.4 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 3835D1F729 for ; Mon, 27 Jun 2022 11:07:33 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZED8qJIR"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234407AbiF0LGj (ORCPT ); Mon, 27 Jun 2022 07:06:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233832AbiF0LGi (ORCPT ); Mon, 27 Jun 2022 07:06:38 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F5986467 for ; Mon, 27 Jun 2022 04:06:37 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id u20so9151142iob.8 for ; Mon, 27 Jun 2022 04:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZXLHh1uXQv/cf0PPRm4LCKMbRccLG3GsBB3lCHIT6hs=; b=ZED8qJIRW804LtLnwoWfPQB5K+VMYRiQ/bBG6jUOrpVyy4hoiBWLpKg2X4samq5xmG GilIPHQjCIshaQkVkCwEIXdC728QJDA1IGTTtM9Z/sw1TDCL18iERpdDblbXifUDv6Rb 1j47gJOs8fNPLGZ9d/xsRHaFRQEL8+SF4f8XXx4r2RRHfxzvA6K78JErT/E7H/VL2hTX 61zi9HhBUOiB+fXVsGrLNwqwv0UayKXcUA1DAB+Iwbszs+jqUc2vK7fF4BT9xJwBL4WU P8GC4QBm2YuU6SquDYvjjy78nJE9vq14JDRw4W2XOOaLI7joc0RpchA0hVij+LmjGQh2 71Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZXLHh1uXQv/cf0PPRm4LCKMbRccLG3GsBB3lCHIT6hs=; b=cLOZ72zjz6il3msGPe27OjiYU2R5t7sk8stissQZ7P6Qe+GCSwvZetwpE4W8QwiM3b x1KtZ0gRd+8aBNUdAQD8adX8nO6HpJpdiW49P75MwwU8OZpn5q1kRbai6J/yyCgHZRhr F7DjtWPbVjGzdYODemVuu6qQ3IBCHFEla1XSEW+YZ55BeY32uCib0XKs5QdmBQliT69E p4wdcduFuEDBnQuvRMofBhc8j9SeDOou97qgb7tsEGbMvB1hHfgrpwpCc2/mxBCVC+m9 sBKX+55Ty5rWLEPzhcpBYVmI+lBCZKjVthxdNc1cPmqquY7IeH6eqIhUigiSUcXvUq36 Ff0w== X-Gm-Message-State: AJIora+DnE8G6Wc7Kzn4XTiev+9ZhA9eluf4Fc0aOXQXuh57SnyI/GYs p0DZQr5mOpAGW+j8H5BRKzJJ5/LlISHS11CHioAzp1VUnfI= X-Google-Smtp-Source: AGRyM1uOARZfZYjPJt1B4RWoHmdQNnaPxDB7HMlVSXtTL3qSEfuvDKPSCyRMX048epCxU6BwI/O9BODL5/Bf1UGEduI= X-Received: by 2002:a05:6638:ec9:b0:339:c3a2:b14c with SMTP id q9-20020a0566380ec900b00339c3a2b14cmr7543198jas.128.1656327996799; Mon, 27 Jun 2022 04:06:36 -0700 (PDT) MIME-Version: 1.0 References: <220624.86letmi383.gmgdl@evledraar.gmail.com> In-Reply-To: From: ZheNing Hu Date: Mon, 27 Jun 2022 19:06:25 +0800 Message-ID: Subject: Re: [PATCH v3] ls-files: introduce "--format" option To: Junio C Hamano Cc: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , ZheNing Hu via GitGitGadget , Git List , Christian Couder , Phillip Wood Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano =E4=BA=8E2022=E5=B9=B46=E6=9C=8827=E6=97= =A5=E5=91=A8=E4=B8=80 16:22=E5=86=99=E9=81=93=EF=BC=9A > > ZheNing Hu writes: > > >> >> + else if (skip_prefix(start, "(path)", &p)) > >> >> + write_name_to_buf(sb, data->pathname); > >> > >> These are just "values". > >> ... > >> >> + else if (skip_prefix(start, "(size)", &p)) > >> >> + strbuf_addf(sb, "size: %u", sd->sd_size); > >> >> + else if (skip_prefix(start, "(flags)", &p)) > >> >> + strbuf_addf(sb, "flags: %x", data->ce->ce_flags); > >> > >> These are not. > >> > > ... If someone else > > need them for some reason, we can add them back. > > If someone else needs to see "size:" printed in front of the value > of sd_size member, we DO NOT HAVE TO DO ANYTHING! That someone else > can write "--format=3Dsize: %(size)" to do so themselves. > > Oh, sorry, I mean if someone need some atoms from %(size) to %(flags), we c= an add them back.