From: ZheNing Hu <adlternative@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Hariom Verma <hariom18599@gmail.com>,
Bagas Sanjaya <bagasdotme@gmail.com>
Subject: Re: [PATCH 0/4] [GSOC][RFC] ref-filter: add %(rest) atom
Date: Wed, 9 Jun 2021 11:55:43 +0800 [thread overview]
Message-ID: <CAOLTT8RURwom91VqFATjMEGGe5NJRgyWSojCC=TH8DwG+7MeSA@mail.gmail.com> (raw)
In-Reply-To: <xmqqtum7ln9m.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> 于2021年6月9日周三 上午11:39写道:
>
> "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > In order to let git cat-file --batch reuse ref-filter logic, in this
> > version, the atom %(rest) is added to ref-filter.
> >
> > Change from last version:
> >
> > 1. Deleted two commit about %(raw:textconv) and %(raw:filters), their
> > construction will be after letting cat-file --batch uses ref-filter
> > logic.
> > 2. Exchange the order of the definition of "cmp_fn" and the declaration of
> > "a_size" and "b_size" in cmp_ref_sorting(), to avoid breaking
> > -Wdecl-after-stmt.
> > 3. Delete --rest option, "git for-each-ref" family will reject %(rest) by
> > default.
> > 4. Add GPG prefix to some %(raw) tests.
> >
> > ZheNing Hu (4):
> > [GSOC] ref-filter: add obj-type check in grab contents
> > [GSOC] ref-filter: add %(raw) atom
> > [GSOC] ref-filter: use non-const ref_format in *_atom_parser()
> > [GSOC] ref-filter: add %(rest) atom
>
> Thanks, will replace.
It’s worth mentioning that this patch still fails the github CI test. [1]
t6300-for-each-ref.sh:
274: Verify sorts with raw
275: Verify sorts with raw:size
278: empty raw refs with %(if)
There is no such breakage on my local machine.
[1] https://github.com/gitgitgadget/git/pull/976/checks?check_run_id=2774963705
next prev parent reply other threads:[~2021-06-09 3:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 14:37 [PATCH 0/4] [GSOC][RFC] ref-filter: add %(rest) atom ZheNing Hu via GitGitGadget
2021-06-08 14:37 ` [PATCH 1/4] [GSOC] ref-filter: add obj-type check in grab contents ZheNing Hu via GitGitGadget
2021-06-08 14:38 ` [PATCH 2/4] [GSOC] ref-filter: add %(raw) atom ZheNing Hu via GitGitGadget
2021-06-08 14:38 ` [PATCH 3/4] [GSOC] ref-filter: use non-const ref_format in *_atom_parser() ZheNing Hu via GitGitGadget
2021-06-08 14:38 ` [PATCH 4/4] [GSOC] ref-filter: add %(rest) atom ZheNing Hu via GitGitGadget
2021-06-09 3:39 ` [PATCH 0/4] [GSOC][RFC] " Junio C Hamano
2021-06-09 3:55 ` ZheNing Hu [this message]
2021-06-09 7:16 ` Junio C Hamano
2021-06-09 16:11 ` [PATCH v2 " ZheNing Hu via GitGitGadget
2021-06-09 16:11 ` [PATCH v2 1/4] [GSOC] ref-filter: add obj-type check in grab contents ZheNing Hu via GitGitGadget
2021-06-09 16:11 ` [PATCH v2 2/4] [GSOC] ref-filter: add %(raw) atom ZheNing Hu via GitGitGadget
2021-06-09 16:12 ` [PATCH v2 3/4] [GSOC] ref-filter: use non-const ref_format in *_atom_parser() ZheNing Hu via GitGitGadget
2021-06-09 16:12 ` [PATCH v2 4/4] [GSOC] ref-filter: add %(rest) atom ZheNing Hu via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLTT8RURwom91VqFATjMEGGe5NJRgyWSojCC=TH8DwG+7MeSA@mail.gmail.com' \
--to=adlternative@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=hariom18599@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).