From: ZheNing Hu <adlternative@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v4] [GSOC] ref-filter: fix read invalid union member bug
Date: Tue, 11 May 2021 21:31:02 +0800 [thread overview]
Message-ID: <CAOLTT8RTtKiCX1EfrMAVdWWxRbpF2nW3ri1NSVQ-tqmpdDUOvw@mail.gmail.com> (raw)
In-Reply-To: <xmqq7dk5mn2s.fsf@gitster.g>
> > Fine, I guess the reason for this mystery is I "push" this branch to github
> > and you haven't done it. That may not be due to the platform. Because I
> > can see no this bug happening when I use a new git repo without "git push",
> > and I test in archlinux or deepin, this bug will happen in these environments.
>
> Sorry, you lost me. I was talking about what happens in the new
> test you added to t6302 not failing as designed, and there shouldn't
> be "I've pushed but you haven't pushed to GitHub" distinction. The
> test is running in a brand-new repository just created for the sole
> purpose of running the test after all.
>
Well, there are some expression problems here, I just want to express:
This bug is only triggered after I push and Git adds some config during
the push process. And then those config effort %(push) behavior.
> So in short, the test script added to t6302 in the v4 patch was not
> testing what it was supposed to be testing, as it didn't have the
> configuration items related to %(push) atom necessary to trigger the
> error?
>
Truly.
> That I can believe. I was starting to worry if there was something
> more subtle going on, but I am glad that it was only an uncooked
> patch submitted without checking.
>
Me too, I want to complain a little bit: this bug is too difficult to locate.
> > I guess you also saw this bug:
> >
> > BUG: ref-filter.c:1544: unhandled RR_* enum
>
> No, I didn't. I just tried to make sure the new test was truly
> checking the existing breakage by partially reverting the code fix,
> and saw that the new test did not fail.
>
I understand.
> Thanks.
Thanks.
--
ZheNing Hu
next prev parent reply other threads:[~2021-05-11 13:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 15:31 [PATCH] [GSOC] ref-filter: solve bugs caused by enumeration ZheNing Hu via GitGitGadget
2021-05-06 1:53 ` Junio C Hamano
2021-05-06 5:02 ` ZheNing Hu
2021-05-06 5:35 ` Junio C Hamano
2021-05-06 10:39 ` ZheNing Hu
2021-05-06 11:20 ` Junio C Hamano
2021-05-06 11:52 ` ZheNing Hu
2021-05-06 21:20 ` Junio C Hamano
2021-05-07 4:32 ` ZheNing Hu
2021-05-07 4:49 ` Junio C Hamano
2021-05-07 5:09 ` ZheNing Hu
2021-05-06 16:31 ` [PATCH v2] [GSOC] ref-filter: fix read invalid union member bug ZheNing Hu via GitGitGadget
2021-05-08 15:26 ` [PATCH v3] " ZheNing Hu via GitGitGadget
2021-05-10 7:21 ` Junio C Hamano
2021-05-10 12:35 ` ZheNing Hu
2021-05-10 7:27 ` Junio C Hamano
2021-05-10 12:51 ` ZheNing Hu
2021-05-10 15:01 ` [PATCH v4] " ZheNing Hu via GitGitGadget
2021-05-11 2:29 ` Junio C Hamano
2021-05-11 6:28 ` ZheNing Hu
2021-05-11 9:30 ` Junio C Hamano
2021-05-11 11:47 ` ZheNing Hu
2021-05-11 13:12 ` Junio C Hamano
2021-05-11 13:31 ` ZheNing Hu [this message]
2021-05-11 15:35 ` [PATCH v5] " ZheNing Hu via GitGitGadget
2021-05-12 1:36 ` Junio C Hamano
2021-05-12 10:37 ` ZheNing Hu
2021-05-12 12:12 ` [PATCH v6] " ZheNing Hu via GitGitGadget
2021-05-12 23:24 ` Junio C Hamano
2021-05-13 9:29 ` ZheNing Hu
2021-05-13 15:13 ` [PATCH v7] " ZheNing Hu via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOLTT8RTtKiCX1EfrMAVdWWxRbpF2nW3ri1NSVQ-tqmpdDUOvw@mail.gmail.com \
--to=adlternative@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).