mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: ZheNing Hu <>
To: Hariom verma <>
	Christian Couder <>
Subject: Re: [OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal]
Date: Mon, 31 Oct 2022 22:26:36 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi, Hariom and NSENGIYUMVA,

Hariom verma <> 于2022年10月28日周五 16:08写道:
> Hi,
> > Olga<> has done great work in “Unifying Git’s
> > format languages” during Outreachy Round 15 and continued even after
> > that [from 28-09-2017 to 04-04-2019]. Her work is mostly related to
> > `cat-file` and `ref-filter`.
> >
> > She already did a pretty nice job in preparing ref-filter for more
> > general usage of its formatting logic. It will give me the possibility
> > to make the migration of pretty.c easier.
> ZheNing Hu continued the Olga's work during GSoC'21. You can tell a
> bit more about that too.

I'm afraid I'm skeptical about the progress of this project. Yes, this
project has
been going on for too long, probably 3 years, and it is long overdue
to be merged
into master. Maybe we all need to rethink the nature of this project instead of
rushing to start writing code.

As far as I know, these unified format refactor are easy to implement, but as we
use more complex parsing logic, there will be a lot of performance degradation.

I recommend new contributors to perform performance analysis and performance
optimization directly based on the original developer's patches.

> --
> I would review the rest later.
> It seems like you used my proposal as a template. Just want to let you
> know, you are not restricted to using any particular template. Feel
> free to add or remove any section you find relevant.
> Thanks,
> Hariom

I will pay close attention to this issue.

ZheNing Hu

  parent reply	other threads:[~2022-10-31 14:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 11:58 [OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal] NSENGIYUMVA WILBERFORCE
2022-10-28  8:05 ` Hariom verma
2022-10-30 10:13   ` NSENGIYUMVA WILBERFORCE
2022-10-31 13:37     ` NSENGIYUMVA WILBERFORCE
2022-10-31 13:59       ` Hariom verma
2022-10-31 14:26   ` ZheNing Hu [this message]
2022-10-31 14:41     ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).