git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Angus Hammond <angusgh@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] send-email: support coloring dry-run output
Date: Thu, 17 May 2012 15:27:40 +0100	[thread overview]
Message-ID: <CAOBOgRaEnFOJ9=ZHczAq_TNerrrMciG8g0SHYDiKrqfhASU-iA@mail.gmail.com> (raw)
In-Reply-To: <1337260596-15498-1-git-send-email-pclouds@gmail.com>

This seems like it would be a useful patch for those of us using sendmail.
I'll admit I don't know any perl at all, but one bit seems a little
odd to me. Is there a reason you use 3 separate print statements to
deal with the colours on the Sendmail line, but a regex substitution
the second time? I have no idea which would be considered the better
practice but surely we should pick one and be consistent? Unless
there's some difference between the two that I'm missing.
Thanks
Angus

  reply	other threads:[~2012-05-17 14:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17 13:16 [PATCH] send-email: support coloring dry-run output Nguyễn Thái Ngọc Duy
2012-05-17 14:27 ` Angus Hammond [this message]
2012-05-18  4:26   ` Nguyen Thai Ngoc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOBOgRaEnFOJ9=ZHczAq_TNerrrMciG8g0SHYDiKrqfhASU-iA@mail.gmail.com' \
    --to=angusgh@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).