From: jonathan chang <firstname.lastname@example.org> To: Thomas Gummerer <email@example.com> Cc: Eric Sunshine <firstname.lastname@example.org>, Christian Couder <email@example.com>, git <firstname.lastname@example.org> Subject: Re: [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error Date: Fri, 15 Mar 2019 09:55:39 +0800 [thread overview] Message-ID: <CAOAu_YLTft7xmx4xvoM5Qqe0CHjqWrH+DUysHq0zfSEU8vodkg@mail.gmail.com> (raw) In-Reply-To: <20190310175924.GF31533@hank.intra.tgummerer.com> On Mon, Mar 11, 2019 at 1:59 AM Thomas Gummerer <email@example.com> wrote: > > On 03/10, Jonathan Chang wrote: > > Hi, > > > > Thanks for the reviews. > > > > Here are the changes in the second version: > > - bug fixes > > - add preparatory patch > > - seperate different files to different patch > > - change to use test_line_count in a seperate patch > > > > Also I found that there is no such function as test_char_count, > > is it worthwile to add such function? Here are some stat: > > > > `git grep 'test_line_count' | wc -l` = 626 > > `git grep 'wc -l' | wc -l` = 294 > > `git grep 'wc -c' | wc -l` = 68 > > I do think it would be helpful to introduce that helper, especially if > it is useful in this patch series. There seem to be enough other > places where it can be useful to make it worth adding the helper. Thanks for the feedback. > > -- >8 -- > > > > This is a preparatory step prior to removing the pipes after git > > commands, which discards git's exit code and may mask a crash. > > The commit message should also describe why we need this preparatory > step. Maybe something like: > > To reduce the noise in when refactoring this pipeline in a > subsequent commit fix the indentation. This has been wrong > since the refactoring done in 1b5b2b641a ("t0000: modernise > style", 2012-03-02), but carries no meaning. > > > Signed-off-by: Jonathan Chang <firstname.lastname@example.org> > > > > Out of curiosity, how did you create the patch? 'git format-patch' > would add a '---' line followed by the diffstat, where you would > usually put the commentary that you put before the scissors line. It > seems like 'git am' still handles this fine, which I didn't know, just > something I noticed because I'm used to the other format. I believe I used git for that. But I cannot think of why it happened nor reproduce it. > Since this patch series is now 5 patches, that commentary should go > into a cover letter (see the --cover-letter option in format-patch), > so the reviewers can read that first, and read the patches with that > in mind, focusing on the patch only, and not additional commentary > that applies to the whole series when reading the patch. I wasn't aware of this option. I tried to produce the format in others cover letter using 'git diff' and options like '--stat', '--summary', with no success. I consulted Documentation/SubmittingPatches, where I got the idea of cover letter, but it doesn't mention the option '--cover-letter' and the idea of cover letter is even confused with '--notes'. I just reread some of the GSoC related mails in the mailing list and found one that introduced the usage of 'cover-letter', '--range-diff' and '--interdiff'. As a newbie, I personally think it would be helpful to include theses options along with others mentioned in SubmittingPatches. : Documentation/SubmittingPatches: > You often want to add additional explanation about the patch, > other than the commit message itself. Place such "cover letter" > material between the three-dash line and the diffstat. For > patches requiring multiple iterations of review and discussion, > an explanation of changes between each iteration can be kept in > Git-notes and inserted automatically following the three-dash > line via `git format-patch --notes`. : https://public-inbox.org/git/CAPig+cSsAufCnHPJfjQd8A778UNAsXEst1m+ekQ7T83=2mMUnw@mail.gmail.com/
next prev parent reply other threads:[~2019-03-15 1:55 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-09 15:45 [GSoC][PATCH] tests: avoid using pipes Jonathan Chang 2019-03-09 16:45 ` Thomas Gummerer 2019-03-10 8:07 ` [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error Jonathan Chang 2019-03-10 8:08 ` [GSoC][PATCH v2 2/5] t0000-basic: avoid using pipes Jonathan Chang 2019-03-10 8:09 ` [GSoC][PATCH v2 3/5] t0003-attributes: " Jonathan Chang 2019-03-10 8:10 ` [GSoC][PATCH v2 4/5] t0022-crlf-rename: " Jonathan Chang 2019-03-10 8:11 ` [GSoC][PATCH v2 5/5] t0000-basic: use test_line_count instead of wc -l Jonathan Chang 2019-03-10 9:50 ` Eric Sunshine 2019-03-11 16:10 ` ttjtftx 2019-03-10 10:03 ` [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes Eric Sunshine [not found] ` <CAOAu_YJKNjGd3mw7K17ySQJeF4XxC+V00FFEYA7o593riEGN1g@mail.gmail.com> 2019-03-11 15:54 ` Fwd: " ttjtftx 2019-03-10 10:13 ` [GSoC][PATCH v2 3/5] t0003-attributes: " Eric Sunshine 2019-03-15 1:56 ` jonathan chang 2019-03-10 17:59 ` [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error Thomas Gummerer 2019-03-15 1:55 ` jonathan chang [this message] 2019-03-15 12:48 ` Christian Couder 2019-03-10 6:05 ` [GSoC][PATCH] tests: avoid using pipes Christian Couder 2019-03-10 8:27 ` ttjtftx 2019-03-10 15:05 ` Christian Couder [not found] ` <CAOAu_YL8heWLSznRV8pjLkRZBOEth_7CSmftupx+4+SSx5yztw@mail.gmail.com> 2019-03-11 16:45 ` Fwd: " jonathan chang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAOAu_YLTft7xmx4xvoM5Qqe0CHjqWrH+DUysHq0zfSEU8vodkg@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).