From: jonathan chang <ttjtftx@gmail.com>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Christian Couder" <christian.couder@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtin
Date: Sun, 31 Mar 2019 13:17:00 +0800 [thread overview]
Message-ID: <CAOAu_YKMuy2vWQqZz+=-7JGhce9BEdMqsr8HOKZOJVq=chpqVw@mail.gmail.com> (raw)
In-Reply-To: <20190330193842.GR32487@hank.intra.tgummerer.com>
On Sun, Mar 31, 2019 at 3:38 AM Thomas Gummerer <t.gummerer@gmail.com> wrote:
>
> On 03/30, Jonathan Chang wrote:
> > Signed-off-by: Jonathan Chang <ttjtftx@gmail.com>
> > ---
> > t/t0000-basic.sh | 14 ++++++++------
> > 1 file changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
> > index 3de13daabe..49923c5ff1 100755
> > --- a/t/t0000-basic.sh
> > +++ b/t/t0000-basic.sh
> > @@ -1118,16 +1118,18 @@ P=$(test_oid root)
> >
> > test_expect_success 'git commit-tree records the correct tree in a commit' '
> > commit0=$(echo NO | git commit-tree $P) &&
> > - git show --pretty=raw $commit0 >actual &&
>
> This line has been introduced in a previous commit. If the file was
> called 'output' there already, I think that patch would be just as
> understandable, but this diff would be a little less noisy.
Make sense. I tried to make patches from last iteration untouched,
so I don't break anything. And I was wondering since I'm only
appending patches, if I should also append the PATCH number as
[PATCH v3 4/3], to reduce the number of emails. Now I realize that
by making it a new iteration, we can also make some improvement
to reduce the patch noise.
>
> > - tree=$(sed -n -e "s/^tree //p" -e "/^author /q" actual) &&
> > - test "z$tree" = "z$P"
> > + git show --pretty=raw $commit0 >output &&
> > + echo "$P" >expect &&
> > + sed -n -e "s/^tree //p" -e "/^author /q" output >actual &&
>
> I'd find it a bit more natural to either first create the expect file,
> and then do the 'git show' and 'sed' invocations in two subsequent
> lines, or do them first, and then create the expect files, rather than
> interleaving them.
>
> I'm not sure either of these by itself is worth a new iteration,
> unless there is also something else to fix up. But it's something
> that you might want to keep in mind for future patches.
I thought about all three options, starting with expect files being
the last, but found that most test_cmp seem to have expect file
created first, then decided to make the creation of actual and
expect be on consecutive lines.
Now I would probably move the creation expect to the last line.
Thanks for the review and suggestions.
>
> > + test_cmp expect actual
> > '
> >
> > test_expect_success 'git commit-tree records the correct parent in a commit' '
> > commit1=$(echo NO | git commit-tree $P -p $commit0) &&
> > - git show --pretty=raw $commit1 >actual &&
> > - parent=$(sed -n -e "s/^parent //p" -e "/^author /q" actual) &&
> > - test "z$commit0" = "z$parent"
> > + git show --pretty=raw $commit1 >output &&
> > + echo "$commit0" >expect &&
> > + sed -n -e "s/^parent //p" -e "/^author /q" output >actual &&
> > + test_cmp expect actual
> > '
> >
> > test_expect_success 'git commit-tree omits duplicated parent in a commit' '
> > --
> > 2.21.0
> >
next prev parent reply other threads:[~2019-03-31 5:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 14:27 [GSoC][PATCH v4 0/5] Avoid using pipes Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 1/5] t0000: fix indentation Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 2/5] t0000: avoid using pipes Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 3/5] t0000: use test_line_count instead of wc -l Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtin Jonathan Chang
2019-03-30 19:38 ` Thomas Gummerer
2019-03-31 5:17 ` jonathan chang [this message]
2019-03-31 18:57 ` Thomas Gummerer
2019-03-30 14:27 ` [GSoC][PATCH v4 5/5] t0000: make use of the test_must_be_empty function Jonathan Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOAu_YKMuy2vWQqZz+=-7JGhce9BEdMqsr8HOKZOJVq=chpqVw@mail.gmail.com' \
--to=ttjtftx@gmail.com \
--cc=avarab@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).