From: jonathan chang <firstname.lastname@example.org> To: git <email@example.com> Subject: Fwd: [GSoC][PATCH] tests: avoid using pipes Date: Tue, 12 Mar 2019 00:45:03 +0800 [thread overview] Message-ID: <CAOAu_YK6G8apWPoFJPCCNizr_O-puHUwtU4CE-0_UgCnTSWkgQ@mail.gmail.com> (raw) In-Reply-To: <CAOAu_YL8heWLSznRV8pjLkRZBOEth_7CSmftupx+4+SSx5yztw@mail.gmail.com> Sorry, I forgot to Cc, again. ---------- Forwarded message --------- From: ttjtftx <firstname.lastname@example.org> Date: Tue, Mar 12, 2019 at 12:32 AM Subject: Re: [GSoC][PATCH] tests: avoid using pipes To: Christian Couder <email@example.com> On Sun, Mar 10, 2019 at 11:05 PM Christian Couder <firstname.lastname@example.org> wrote: > > On Sun, Mar 10, 2019 at 9:28 AM ttjtftx <email@example.com> wrote: > > > > On Sun, Mar 10, 2019 at 2:06 PM Christian Couder > > <firstname.lastname@example.org> wrote: > > > > > If you take a look at c6f44e1da5 ("t9813: avoid using pipes", > > > 2017-01-04) you can see the following: > > > > > > - it changes only one test file: t9813-git-p4-preserve-users.sh > > > - its title starts with "t9813: " > > I adapted this format in my second version. > > > > : https://email@example.com > > It's better because each patch changes only one file, but I also > wanted to say that for a microproject you only need to focus on only > one file. So I would you suggest you keep only the patches that are > about "t0000-basic.sh" and drop the patches about > "t0003-attributes.sh" and "t0022-crlf-rename.sh". I will do that as I have made too many mistakes. I decided to do more than one file because I thought it might be too small even for a microproject and that there would be more chances for feedback if I include more files, since the same file tend to have similar conversions needed. > It's also a small nit but your patches start with "t0000-basic: " not > just "t0000: " though the latter format is more frequent in existing > commits than the former. Got it.
prev parent reply other threads:[~2019-03-11 16:45 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-09 15:45 Jonathan Chang 2019-03-09 16:45 ` Thomas Gummerer 2019-03-10 8:07 ` [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error Jonathan Chang 2019-03-10 8:08 ` [GSoC][PATCH v2 2/5] t0000-basic: avoid using pipes Jonathan Chang 2019-03-10 8:09 ` [GSoC][PATCH v2 3/5] t0003-attributes: " Jonathan Chang 2019-03-10 8:10 ` [GSoC][PATCH v2 4/5] t0022-crlf-rename: " Jonathan Chang 2019-03-10 8:11 ` [GSoC][PATCH v2 5/5] t0000-basic: use test_line_count instead of wc -l Jonathan Chang 2019-03-10 9:50 ` Eric Sunshine 2019-03-11 16:10 ` ttjtftx 2019-03-10 10:03 ` [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes Eric Sunshine [not found] ` <CAOAu_YJKNjGd3mw7K17ySQJeF4XxC+V00FFEYA7o593riEGN1g@mail.gmail.com> 2019-03-11 15:54 ` Fwd: " ttjtftx 2019-03-10 10:13 ` [GSoC][PATCH v2 3/5] t0003-attributes: " Eric Sunshine 2019-03-15 1:56 ` jonathan chang 2019-03-10 17:59 ` [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error Thomas Gummerer 2019-03-15 1:55 ` jonathan chang 2019-03-15 12:48 ` Christian Couder 2019-03-10 6:05 ` [GSoC][PATCH] tests: avoid using pipes Christian Couder 2019-03-10 8:27 ` ttjtftx 2019-03-10 15:05 ` Christian Couder [not found] ` <CAOAu_YL8heWLSznRV8pjLkRZBOEth_7CSmftupx+4+SSx5yztw@mail.gmail.com> 2019-03-11 16:45 ` jonathan chang [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAOAu_YK6G8apWPoFJPCCNizr_O-puHUwtU4CE-0_UgCnTSWkgQ@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Fwd: [GSoC][PATCH] tests: avoid using pipes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).