From: ttjtftx <ttjtftx@gmail.com> To: git <git@vger.kernel.org> Cc: Christian Couder <christian.couder@gmail.com>, Thomas Gummerer <t.gummerer@gmail.com> Subject: Fwd: [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes Date: Mon, 11 Mar 2019 23:54:04 +0800 [thread overview] Message-ID: <CAOAu_YJHOQt=6H2q+hMnsmFGsqZyedDO0LpCqNH_8A484iPyWA@mail.gmail.com> (raw) In-Reply-To: <CAOAu_YJKNjGd3mw7K17ySQJeF4XxC+V00FFEYA7o593riEGN1g@mail.gmail.com> Sorry, I forgot to Cc. ---------- Forwarded message --------- From: ttjtftx <ttjtftx@gmail.com> Date: Mon, Mar 11, 2019 at 11:43 PM Subject: Re: [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes To: Eric Sunshine <sunshine@sunshineco.com> On Sun, Mar 10, 2019 at 6:03 PM Eric Sunshine <sunshine@sunshineco.com> wrote: > All of the patches in this series are malformed. There should be a > "---" line right here below your sign-off. The "---" line is > recognized by git-am/git-apply as separating the commit message from > the actual diff(s). I will check it next time. > It is a very well-established custom in Git tests for the files handed > to test_cmp() to be named "expect" and "actual", so this change is not > the most desirable. What you can do instead is: > > git diff-tree -M -r --name-status HEAD^ HEAD >output && > sed -e "s/R[0-9]*/RNUM/" output >actual && > > which allows you to leave the test_cmp() line alone, thus (as a bonus) > makes the patch less noisy. Thanks for the tips! Now I see why "actual" is the most used name for output files.
next prev parent reply other threads:[~2019-03-11 15:54 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-09 15:45 [GSoC][PATCH] tests: " Jonathan Chang 2019-03-09 16:45 ` Thomas Gummerer 2019-03-10 8:07 ` [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error Jonathan Chang 2019-03-10 8:08 ` [GSoC][PATCH v2 2/5] t0000-basic: avoid using pipes Jonathan Chang 2019-03-10 8:09 ` [GSoC][PATCH v2 3/5] t0003-attributes: " Jonathan Chang 2019-03-10 8:10 ` [GSoC][PATCH v2 4/5] t0022-crlf-rename: " Jonathan Chang 2019-03-10 8:11 ` [GSoC][PATCH v2 5/5] t0000-basic: use test_line_count instead of wc -l Jonathan Chang 2019-03-10 9:50 ` Eric Sunshine 2019-03-11 16:10 ` ttjtftx 2019-03-10 10:03 ` [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes Eric Sunshine [not found] ` <CAOAu_YJKNjGd3mw7K17ySQJeF4XxC+V00FFEYA7o593riEGN1g@mail.gmail.com> 2019-03-11 15:54 ` ttjtftx [this message] 2019-03-10 10:13 ` [GSoC][PATCH v2 3/5] t0003-attributes: " Eric Sunshine 2019-03-15 1:56 ` jonathan chang 2019-03-10 17:59 ` [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error Thomas Gummerer 2019-03-15 1:55 ` jonathan chang 2019-03-15 12:48 ` Christian Couder 2019-03-10 6:05 ` [GSoC][PATCH] tests: avoid using pipes Christian Couder 2019-03-10 8:27 ` ttjtftx 2019-03-10 15:05 ` Christian Couder [not found] ` <CAOAu_YL8heWLSznRV8pjLkRZBOEth_7CSmftupx+4+SSx5yztw@mail.gmail.com> 2019-03-11 16:45 ` Fwd: " jonathan chang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOAu_YJHOQt=6H2q+hMnsmFGsqZyedDO0LpCqNH_8A484iPyWA@mail.gmail.com' \ --to=ttjtftx@gmail.com \ --cc=christian.couder@gmail.com \ --cc=git@vger.kernel.org \ --cc=t.gummerer@gmail.com \ --subject='Re: Fwd: [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).