[PATCH] show signature of commit in gitk

[PATCH] show signature of commit in gitk

[Daniel Fahlke]

but still depending on the added --show-signature as argument

longer explanation:
git supports for some time now signed commits, and also show the
signature and its trust level inside the `git log` command.
Now, it can also get shown in gitk.

Signed-off-by: Flyingmana <flyingmana@googlemail.com>
---
 gitk-git/gitk | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gitk-git/gitk b/gitk-git/gitk
index fcc606e..54c167f 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -1674,6 +1674,7 @@ proc parsecommit {id contents listed} {
     set audate {}
     set comname {}
     set comdate {}
+    set comgpg {}
     set hdrend [string first "\n\n" $contents]
     if {$hdrend < 0} {
 	# should never happen...
@@ -1690,6 +1691,9 @@ proc parsecommit {id contents listed} {
 	} elseif {$tag == "committer"} {
 	    set comdate [lrange $line end-1 end]
 	    set comname [join [lrange $line 1 end-2] " "]
+	} elseif {$tag == "gpg:"} {
+	    append comgpg [join [lrange $line 1 end] " "]
+	    append comgpg "\n"
 	}
     }
     set headline {}
@@ -1726,7 +1730,7 @@ proc parsecommit {id contents listed} {
 	set comment [string range $comment 0 $i-1]
     }
     set commitinfo($id) [list $headline $auname $audate \
-			     $comname $comdate $comment $hasnote $diff]
+			     $comname $comdate $comment $hasnote $diff $comgpg]
 }
  proc getcommit {id} {
@@ -7325,6 +7329,7 @@ proc selectline {l isnew {desired_loc {}}
{switch_to_patch 0}} {
     $ctext insert end "[mc "Author"]: [lindex $info 1]  $date\n"
     set date [formatdate [lindex $info 4]]
     $ctext insert end "[mc "Committer"]: [lindex $info 3]  $date\n"
+    $ctext insert end [lindex $info 8]
     if {[info exists idtags($id)]} {
 	$ctext insert end [mc "Tags:"]
 	foreach tag $idtags($id) {
-- 
2.6.3

Re: [PATCH] show signature of commit in gitk

[Daniel Fahlke]

It seems my Patch got no attention yet, is there anything wrong? 
Do I need to ping someone in particular?

On 12/02/2015 08:19 PM, Daniel Fahlke wrote:
> but still depending on the added --show-signature as argument
> 
> longer explanation:
> git supports for some time now signed commits, and also show the
> signature and its trust level inside the `git log` command.
> Now, it can also get shown in gitk.
> 
> Signed-off-by: Flyingmana <flyingmana@googlemail.com>
> ---
>  gitk-git/gitk | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index fcc606e..54c167f 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -1674,6 +1674,7 @@ proc parsecommit {id contents listed} {
>      set audate {}
>      set comname {}
>      set comdate {}
> +    set comgpg {}
>      set hdrend [string first "\n\n" $contents]
>      if {$hdrend < 0} {
>  	# should never happen...
> @@ -1690,6 +1691,9 @@ proc parsecommit {id contents listed} {
>  	} elseif {$tag == "committer"} {
>  	    set comdate [lrange $line end-1 end]
>  	    set comname [join [lrange $line 1 end-2] " "]
> +	} elseif {$tag == "gpg:"} {
> +	    append comgpg [join [lrange $line 1 end] " "]
> +	    append comgpg "\n"
>  	}
>      }
>      set headline {}
> @@ -1726,7 +1730,7 @@ proc parsecommit {id contents listed} {
>  	set comment [string range $comment 0 $i-1]
>      }
>      set commitinfo($id) [list $headline $auname $audate \
> -			     $comname $comdate $comment $hasnote $diff]
> +			     $comname $comdate $comment $hasnote $diff $comgpg]
>  }
>   proc getcommit {id} {
> @@ -7325,6 +7329,7 @@ proc selectline {l isnew {desired_loc {}}
> {switch_to_patch 0}} {
>      $ctext insert end "[mc "Author"]: [lindex $info 1]  $date\n"
>      set date [formatdate [lindex $info 4]]
>      $ctext insert end "[mc "Committer"]: [lindex $info 3]  $date\n"
> +    $ctext insert end [lindex $info 8]
>      if {[info exists idtags($id)]} {
>  	$ctext insert end [mc "Tags:"]
>  	foreach tag $idtags($id) {
> 

Re: [PATCH] show signature of commit in gitk

[Mike Rappazzo]

On Sun, Dec 13, 2015 at 9:15 AM, Daniel Fahlke <flyingmana@cotya.com> wrote:
> It seems my Patch got no attention yet, is there anything wrong?
> Do I need to ping someone in particular?
>

gitk patches should cc +Paul Mackerras <paulus@samba.org> who maintains gitk