From: Rudy Rigot <rudy.rigot@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Rudy Rigot via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Jeff Hostetler" <git@jeffhostetler.com>,
"Taylor Blau" <me@ttaylorr.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Derrick Stolee" <derrickstolee@github.com>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH v8] status: modernize git-status "slow untracked files" advice
Date: Tue, 29 Nov 2022 18:51:25 -0600 [thread overview]
Message-ID: <CANaDLW+Zuwpk_7jTO5LmWTXDT8LRPPcGARkNtaV6ORioWyZ0tg@mail.gmail.com> (raw)
In-Reply-To: <CANaDLW+ukK2GU7NzkCvXVNc9DX3_93Pp+PHq-WcLpRJizPidVA@mail.gmail.com>
Alright, I tried the "status.enumerateUntrackedDelayMS" approach, but
I couldn't pull it off and now I am stumped.
This is somewhat frustrating, so I'd welcome guidance if anyone has
time and is interested. Since this doesn't actually work, I don't
think I should create an actual patch for it on the mailing list, so
here are two other ways to show what I've got, I hope they're
acceptable:
- in Gist form:
https://gist.github.com/rudyrigot/aa3e8e5ddb4f71fdc7fc0e92d9b7a4b8
- in GitHub compare form:
https://github.com/git/git/compare/master...rudyrigot:git:status_enumerateUntrackedDelayMS
The issues I'm seeing:
- No matter how I set the config from the test, it doesn't seem to
have any effect. I'm thinking I might be doing something wrong in how
I set the value, which I've done in git_status_config in
builtin/commit.c, which very well may be the wrong place.
- Therefore, I've been testing things by changing the default value in
wt_status_prepare in wt-status.c. Setting it at 0 and making the
operator <= instead of < makes the advice display, which tells me that
the logic is sound. Setting at its intended value of 2000 doesn't
display the advice message, as expected. But setting it at -1 also
doesn't display it. I'm a bit puzzled about why that would be, and I'm
wondering: maybe the int is unsigned? It doesn't look like it based on
how the structure field is declared in wt-status.h, but I know my own
limits in C so I could be wrong.
Now, I'm also well aware that Junio raised that advice leaving the
door wide open to not actually solve this as part of this patch; and I
did express in my previous reply that I am not intuitively convinced
there is much value to it for users, although I could be wrong of
course. So with that, if it's better to let it go, that is fine by me
too.
With that in mind, I implemented the alternative that Junio was
proposing instead (assigning the value of `s->untracked_in_ms`), and
it seems to work all good. It just passed CI, so I'm about to submit
that as a patch, with every other piece of feedback also addressed.
Unrelated note: I noticed that the first 2 bits of feedback applied to
docs that were part of past patches, but were removed in the last
patch. The rest of the doc feedback was current, so I was able to
implement them, but obviously I couldn't implement the first 2 ones,
since the issues they're about are gone.
next prev parent reply other threads:[~2022-11-30 0:52 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 13:04 [PATCH] fsmonitor: long status advice adapted to the fsmonitor use case Rudy Rigot via GitGitGadget
2022-10-15 13:08 ` Rudy Rigot
2022-10-17 15:39 ` Jeff Hostetler
2022-10-17 16:59 ` Rudy Rigot
2022-10-20 12:56 ` Jeff Hostetler
2022-10-20 20:17 ` Rudy Rigot
2022-10-24 14:55 ` Jeff Hostetler
2022-10-29 0:06 ` [PATCH v2] status: long status advice adapted to recent capabilities Rudy Rigot via GitGitGadget
2022-11-02 19:45 ` Jeff Hostetler
2022-11-02 20:34 ` Rudy Rigot
2022-11-02 23:59 ` Taylor Blau
2022-11-03 14:28 ` Rudy Rigot
2022-11-04 8:52 ` Ævar Arnfjörð Bjarmason
2022-11-04 15:33 ` Rudy Rigot
2022-11-04 21:38 ` Taylor Blau
2022-11-02 21:27 ` [PATCH v3] " Rudy Rigot via GitGitGadget
2022-11-04 21:40 ` Taylor Blau
2022-11-07 20:02 ` Derrick Stolee
2022-11-07 23:19 ` Taylor Blau
2022-11-15 16:38 ` Jeff Hostetler
2022-11-07 20:01 ` Derrick Stolee
2022-11-07 20:20 ` Eric Sunshine
2022-11-07 20:31 ` Rudy Rigot
2022-11-10 4:46 ` [PATCH v4] " Rudy Rigot via GitGitGadget
2022-11-10 5:42 ` Eric Sunshine
2022-11-10 17:01 ` Rudy Rigot
2022-11-10 17:30 ` Eric Sunshine
2022-11-10 17:47 ` Rudy Rigot
2022-11-10 20:04 ` [PATCH v5] " Rudy Rigot via GitGitGadget
2022-11-15 16:39 ` Jeff Hostetler
2022-11-15 16:42 ` Rudy Rigot
2022-11-15 17:26 ` Eric Sunshine
2022-11-15 17:45 ` Rudy Rigot
2022-11-15 18:06 ` Eric Sunshine
2022-11-15 18:08 ` Rudy Rigot
2022-11-15 21:19 ` [PATCH v6] " Rudy Rigot via GitGitGadget
2022-11-21 5:06 ` Eric Sunshine
2022-11-21 15:54 ` Rudy Rigot
2022-11-21 16:17 ` Eric Sunshine
2022-11-22 16:52 ` Rudy Rigot
2022-11-22 17:18 ` Eric Sunshine
2022-11-22 17:24 ` Eric Sunshine
2022-11-22 17:29 ` Rudy Rigot
2022-11-22 17:40 ` Eric Sunshine
2022-11-22 18:07 ` Eric Sunshine
2022-11-22 19:19 ` Rudy Rigot
2022-11-22 19:48 ` Eric Sunshine
2022-11-22 16:59 ` [PATCH v7] status: modernize git-status "slow untracked files" advice Rudy Rigot via GitGitGadget
2022-11-22 22:07 ` [PATCH v8] " Rudy Rigot via GitGitGadget
2022-11-25 4:58 ` Junio C Hamano
2022-11-29 15:21 ` Rudy Rigot
2022-11-30 0:51 ` Rudy Rigot [this message]
2022-11-30 0:52 ` [PATCH v9] " Rudy Rigot via GitGitGadget
2022-12-01 6:48 ` Junio C Hamano
2022-12-01 15:16 ` Rudy Rigot
2022-12-01 22:45 ` Junio C Hamano
2022-12-01 22:57 ` Rudy Rigot
2023-05-11 5:17 ` [PATCH v8] " Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANaDLW+Zuwpk_7jTO5LmWTXDT8LRPPcGARkNtaV6ORioWyZ0tg@mail.gmail.com \
--to=rudy.rigot@gmail.com \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).