From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 4F1501F4D7 for ; Thu, 19 May 2022 12:49:11 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pCeRCbs2"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237965AbiESMs4 (ORCPT ); Thu, 19 May 2022 08:48:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237337AbiESMsy (ORCPT ); Thu, 19 May 2022 08:48:54 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57C26B41CD for ; Thu, 19 May 2022 05:48:53 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id m1so4599920qkn.10 for ; Thu, 19 May 2022 05:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=GMyVD0gabRpdLcJ9ktWl6tn+p99bE5Vh1ivItf3pYBo=; b=pCeRCbs2mfcWtpkRAKWHvKREhsBPemO9g4khVmI0kwPd3tap7mEhGJ7Wn0PuvEL4wU gk65MAZ/1KodefrHGUw3ELP55ZjAou8y2A6YnzzpP297Be+5FXtg6Hu0iqhfe29YPgrQ oCgbF4f4LmAv97FWbmsa1cNN2vI3+M/yRIga9S4MwZwnEDvdLLAPoRHy4tnk5aqu2dHL DaWFQuds6C66Z35tlz3L6cL4LBCjPU/X8oo6AR2053wK0kEcxMUy6cnrrOi9Fmfdx+tm eV4jnKzK/jjVArVWEQimiGXA33jSTJ60ln5AuRwOjhOM38f5cUHcGB77ogRX+mL58dpn OgMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=GMyVD0gabRpdLcJ9ktWl6tn+p99bE5Vh1ivItf3pYBo=; b=2EXm4pim1muDjtBb4niG5hHxBSfHGumpw/unSgTA8w4Gb9hcN+bcZP4rZ3XAgU7Tdj eGcmrfCL12GPqd6cSrk0RuQLAyOWGaPi9DgAefPlDiyybC5Oa+5FRUXTgmmIe4qkSNWi p1kbRdFgkEmpcbSqdU4chE/lod14z50N3ez8E3bMEvD+IvsnAhZEyKde5kyUPePuq1TJ Ow4bV+/RDtDK5uRbOtYKcPNruyQkEXAvkIHnexImWJU2VD4fAJnxU0iibs0i2jmsAQqo Bowf/Y7m+09eqjwa+YPX09OUIqfECW7/y/xnX5qMIPN0l0bht2Td0i6+LgyxpadwItiS 0xjA== X-Gm-Message-State: AOAM532VBuRc5Str6nBRvOYawU/UouPPzzTcA8pCCTJjfrSykPRoqlhD 5Cc9uqrLuTi1aFTZWssRxqVzIl9hkU38DSnNV8g= X-Google-Smtp-Source: ABdhPJz1VWL2xfgeFXkrzSFFIX1bO4pUtNjniztVbXeUeCf17YU/Iqb4q3LdvJ48Zmcf3B41441zkCV0T1IiaaX/6Sk= X-Received: by 2002:a05:620a:573:b0:69f:cf74:720 with SMTP id p19-20020a05620a057300b0069fcf740720mr2772857qkp.683.1652964532531; Thu, 19 May 2022 05:48:52 -0700 (PDT) MIME-Version: 1.0 References: <20220503132354.9567-1-worldhello.net@gmail.com> <20220519081548.3380-3-worldhello.net@gmail.com> <220519.86pmk96fhv.gmgdl@evledraar.gmail.com> In-Reply-To: <220519.86pmk96fhv.gmgdl@evledraar.gmail.com> From: Jiang Xin Date: Thu, 19 May 2022 20:48:41 +0800 Message-ID: Subject: Re: [PATCH v2 2/9] Makefile: generate "po/git.pot" from stable LOCALIZED_C To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: Junio C Hamano , Git List , Jiang Xin , Alexander Shopov , Jordi Mas , =?UTF-8?Q?Matthias_R=C3=BCster?= , Jimmy Angelakos , =?UTF-8?Q?Christopher_D=C3=ADaz?= , =?UTF-8?Q?Jean=2DNo=C3=ABl_Avila?= , Bagas Sanjaya , Alessandro Menti , Gwan-gyeong Mun , Arusekk , Daniel Santos , Dimitriy Ryazantcev , Peter Krefting , Emir SARI , =?UTF-8?B?VHLhuqduIE5n4buNYyBRdcOibg==?= , Fangyi Zhou , Yi-Jyun Pan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, May 19, 2022 at 5:25 PM =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason wrote: > > diff --git a/Makefile b/Makefile > > index 83e968e2a4..60ca42c268 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -2714,7 +2714,8 @@ XGETTEXT_FLAGS_SH =3D $(XGETTEXT_FLAGS) --languag= e=3DShell \ > > --keyword=3Dgettextln --keyword=3Deval_gettextln > > XGETTEXT_FLAGS_PERL =3D $(XGETTEXT_FLAGS) --language=3DPerl \ > > --keyword=3D__ --keyword=3DN__ --keyword=3D"__n:1,2" > > -LOCALIZED_C =3D $(C_OBJ:o=3Dc) $(LIB_H) $(GENERATED_H) > > +LOCALIZED_C =3D $(FOUND_C_SOURCES) $(SCALAR_SOURCES) \ > > + $(FOUND_H_SOURCES) $(GENERATED_H) > > The SCALAR_SOURCES seems snuck in here, but it's worth noting in the > commit message that we effectively had it here before as part of C_OBJ. Agree.