From: Jiang Xin <worldhello.net@gmail.com>
To: Brian Gesiak <modocache@gmail.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [l10n] date: Note for translators not included in .po files
Date: Thu, 17 Apr 2014 09:41:42 +0800 [thread overview]
Message-ID: <CANYiYbGC0MsYFMv2kUjDxE64tO_gXb6gtFoRMNv4zpyTcHdT+w@mail.gmail.com> (raw)
In-Reply-To: <CAN7MxmV5tzvGTTG+aOL73fLhbXc7YeOWvYwLkMyad0=mvffMHQ@mail.gmail.com>
2014-04-17 6:51 GMT+08:00 Brian Gesiak <modocache@gmail.com>:
> A note for translators in date.c is not included in git.pot.
> Namely, the following note from date.c:147 is not included
> (https://github.com/git/git/blob/v1.9.2/date.c#L147):
>
> /* TRANSLATORS: "%s" is "<n> years" */
>
Comments for translators will be extracted to pot file automatically,
when run xgettext with "--add-comments" option.
-c, --add-comments
place all comment blocks preceding keyword lines in output file
For example, the comments in the following code blocks will
be extracted.
/* TRANSLATORS: "will be extracted." */
strbuf_addf(&sb, Q_("%lu year", "%lu years", years), years);
strbuf_addf(&sb,
/* TRANSLATORS: "will be extracted." */
Q_("%lu year", "%lu years", years), years);
But if the comment is not right before the l10n markers, such
comments will not be extracted. E.g.
/* TRANSLATORS: "WARNING: will NOT be extracted." */
strbuf_addf(&sb,
Q_("%lu year", "%lu years", years), years);
/* TRANSLATORS: "WARNING: will NOT be extracted." */
strbuf_addf(&sb, Q_(
"%lu year", "%lu years", years), years);
I will scan all the codes and make a fix.
> This is a very useful note for translators (in fact, I think
> the zh_CN translation for date.c:149 might be a little off
> because this note was not included. My Mandarin is rusty,
> but I believe "<n> years, <m> months ago" should be expressed
> without a comma).
>
> According to po/README, the l10n coordinator is responsible
> for updating the git.pot file. Would it be possible to update it based
> on v1.9.2 and include the above comment?
>
I could generate a new git.pot for "maint" branch, but fixes for codes
may only contribute to "master" branch.
--
Jiang Xin
next prev parent reply other threads:[~2014-04-17 1:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 22:51 [l10n] date: Note for translators not included in .po files Brian Gesiak
2014-04-17 1:41 ` Jiang Xin [this message]
2014-04-17 5:37 ` [PATCH 0/3] extract proper comments for l10n translators Jiang Xin
2014-04-17 5:50 ` Jiang Xin
2014-04-17 18:12 ` Junio C Hamano
2014-04-17 5:37 ` [PATCH 1/3] i18n: Fixes uncatchable comments for translators Jiang Xin
2014-04-17 5:37 ` [PATCH 2/3] i18n: Only extract comments marked by special tag Jiang Xin
2014-04-17 18:08 ` Junio C Hamano
2014-04-18 6:03 ` Jiang Xin
2014-04-18 16:52 ` Junio C Hamano
2014-04-18 17:48 ` Junio C Hamano
2014-04-17 5:37 ` [PATCH 3/3] i18n: Remove obsolete comments for translators Jiang Xin
2014-04-17 6:27 ` [l10n] date: Note for translators not included in .po files Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANYiYbGC0MsYFMv2kUjDxE64tO_gXb6gtFoRMNv4zpyTcHdT+w@mail.gmail.com \
--to=worldhello.net@gmail.com \
--cc=git@vger.kernel.org \
--cc=modocache@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).